Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): observable not within angular zone #354

Closed
jeffbcross opened this issue Jul 13, 2016 · 0 comments
Closed

fix(auth): observable not within angular zone #354

jeffbcross opened this issue Jul 13, 2016 · 0 comments
Assignees
@jeffbcross
Labels
type: bug
Milestone
Beta.3

Comments

@jeffbcross
Copy link
Contributor

The auth observable, af.auth, is not in the angular zone when new auth objects are emitted. @StephenFluin has a reproduction in https://github.com/StephenFluin/ames

This is causing Angular's change detection not to run until the next tick.
@jeffbcross jeffbcross added this to the Beta.3 milestone Jul 13, 2016
@jeffbcross jeffbcross self-assigned this Jul 13, 2016
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Jul 19, 2016
@jeffbcross
fix(auth): add scheduler to schedule onAuth events through Angular zone
99e02f4 
Closes angular#354
@jeffbcross jeffbcross mentioned this issue Jul 19, 2016
Merged
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Jul 20, 2016
@jeffbcross
fix(auth): add scheduler to schedule onAuth events through Angular zone
9c67575 
Closes angular#354
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Jul 22, 2016
@jeffbcross
fix(auth): add scheduler to schedule onAuth events through Angular zone
1778ed3 
Closes angular#354
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Jul 22, 2016
@jeffbcross
fix(auth): add scheduler to schedule onAuth events through Angular zone
7fb596e 
Closes angular#354
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Jul 28, 2016
@jeffbcross
fix(auth): add scheduler to schedule onAuth events through Angular zone
e4db9fb 
Closes angular#354
jeffbcross added a commit that referenced this issue Jul 28, 2016
@jeffbcross
fix(auth): add scheduler to schedule onAuth events through Angular zo…
3615318 
…ne (#368)

Closes #354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffbcross jeffbcross

Labels
type: bug
Projects
None yet
Milestone
Beta.3
Development

No branches or pull requests
1 participant
@jeffbcross