Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-cli): emitting references to ngtypecheck files #57138

Closed
wants to merge 1 commit into from
Closed

fix(compiler-cli): emitting references to ngtypecheck files #57138

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Follow-up to #56961 which doesn't appear to have caught all the cases. This change moves the pre-emit untagging to NgCompiler.prepareEmit which seems to cover a bit more comared to NgtscProgram.emit.

Fixes #57135.

@crisbeto
fix(compiler-cli): emitting references to ngtypecheck files
2dd16b3 
Follow-up to angular#56961 which doesn't appear to have caught all the cases. This change moves the pre-emit untagging to `NgCompiler.prepareEmit` which seems to cover a bit more comared to `NgtscProgram.emit`.

Fixes angular#57135.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels Jul 26, 2024
@crisbeto crisbeto requested a review from JoostK July 26, 2024 07:11
@ngbot ngbot bot added this to the Backlog milestone Jul 26, 2024
JoostK
JoostK approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, this makes sense; while NgCompiler is internal, both the CLI and ng-packagr call into it directly to be able to use TS's builder APIs for incremental compilations.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jul 26, 2024
@crisbeto
Copy link
Member Author

Note to self: will need to cherry pick this into patch.

@dylhunn
Copy link
Contributor

dylhunn commented Jul 26, 2024

This PR was merged into the repository by commit 0f0a1f2.

The changes were merged into the following branches: main

@dylhunn dylhunn closed this in 0f0a1f2 Jul 26, 2024
vladboisa pushed a commit to vladboisa/angular that referenced this pull request Jul 29, 2024
@crisbeto @vladboisa
fix(compiler-cli): emitting references to ngtypecheck files (angular#…
2d572cc 
…57138)

Follow-up to angular#56961 which doesn't appear to have caught all the cases. This change moves the pre-emit untagging to `NgCompiler.prepareEmit` which seems to cover a bit more comared to `NgtscProgram.emit`.

Fixes angular#57135.

PR Close angular#57138
crisbeto added a commit to crisbeto/angular that referenced this pull request Jul 31, 2024
@crisbeto
fix(compiler-cli): emitting references to ngtypecheck files (angular#…
a55347a 
…57138)

Follow-up to angular#56961 which doesn't appear to have caught all the cases. This change moves the pre-emit untagging to `NgCompiler.prepareEmit` which seems to cover a bit more comared to `NgtscProgram.emit`.

Fixes angular#57135.

PR Close angular#57138
@crisbeto crisbeto mentioned this pull request Jul 31, 2024
Closed
thePunderWoman pushed a commit that referenced this pull request Jul 31, 2024
@crisbeto @thePunderWoman
fix(compiler-cli): emitting references to ngtypecheck files (#57138) (#…
1f9e090 
…57202)

Follow-up to #56961 which doesn't appear to have caught all the cases. This change moves the pre-emit untagging to `NgCompiler.prepareEmit` which seems to cover a bit more comared to `NgtscProgram.emit`.

Fixes #57135.

PR Close #57138

PR Close #57202
@josuedeleonaguilar josuedeleonaguilar mentioned this pull request Aug 2, 2024
Open
@mayankv87 mayankv87 mentioned this pull request Aug 4, 2024
Open
@WontonSam WontonSam mentioned this pull request Aug 15, 2024
Open
@fjaguado fjaguado mentioned this pull request Aug 22, 2024
Open
This was referenced Aug 22, 2024
Open
Open
@rishabh114 rishabh114 mentioned this pull request Aug 22, 2024
Open
@tFaster tFaster mentioned this pull request Aug 22, 2024
Open
@kidwen kidwen mentioned this pull request Aug 22, 2024
Merged
@lakshamanr lakshamanr mentioned this pull request Aug 22, 2024
Closed
@ambrose40 ambrose40 mentioned this pull request Aug 22, 2024
Open
@WontonSam WontonSam mentioned this pull request Aug 24, 2024
Open
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK approved these changes

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

ngtypecheck reference added in compiled TS files for libraries with multiple secondary entrypoints
4 participants
@crisbeto @dylhunn @JoostK @alxhub