fix(common): don't generate srcset if noopImageLoader is used #47804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
area: common
AndrewKushnir
added
the
action: presubmit
AndrewKushnir
added
action: merge
dylhunn
added
action: cleanup
|
@atcastle @AndrewKushnir This looks to need a rebase. |
Do not generate a srcset if the loader being used is the default noopImageLoader. This loader does not take width into account, so it does not make sense to use it with srcsets.
AndrewKushnir
force-pushed
the
no-noop-srcsets
branch
from
cfff0af to
e716a69
Compare
AndrewKushnir
added
action: merge
|
@dylhunn this PR is also rebased. Thank you. |
|
This PR was merged into the repository by commit 38ec156. |
dylhunn
pushed a commit
that referenced
this pull request
Oct 19, 2022
Do not generate a srcset if the loader being used is the default noopImageLoader. This loader does not take width into account, so it does not make sense to use it with srcsets. PR Close #47804
nouraellm
pushed a commit
to nouraellm/angular
that referenced
this pull request
Nov 6, 2022
…r#47804) Do not generate a srcset if the loader being used is the default noopImageLoader. This loader does not take width into account, so it does not make sense to use it with srcsets. PR Close angular#47804
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
…r#47804) Do not generate a srcset if the loader being used is the default noopImageLoader. This loader does not take width into account, so it does not make sense to use it with srcsets. PR Close angular#47804
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where srcsets were being generated even when the noopImageLoader (default) was being used in NgOptimizedImage. Srcsets shouldn't be generated in that case because the noopImageLoader doesn't consume the width value for images.