Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): enable the new directive composition API #47642

Closed
wants to merge 1 commit into from
Closed

feat(core): enable the new directive composition API #47642

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 5, 2022 •
edited
Loading

Enables the new directive composition API by exposing the hostDirectives property on the Directive and Component decorators. Also cleans up some casts that were put in place while the feature was being developed.

Fixes #8785.

@crisbeto
feat(core): enable the new directive composition API
6a8bd9f 
Enables the new directive composition API by exposing the `hostDirectives` property on the `Directive` and `Component` decorators. Also cleans up some casts that were put in place while the feature was being developed.

Fixes angular#8785.
@pullapprove pullapprove bot requested a review from alxhub October 5, 2022 16:18
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Oct 5, 2022
@crisbeto crisbeto added this to the v15 feature freeze blockers milestone Oct 5, 2022
@ngbot ngbot bot removed this from the v15 feature freeze blockers milestone Oct 5, 2022
@crisbeto crisbeto added the area: core Issues related to the framework runtime label Oct 5, 2022
@ngbot ngbot bot added this to the Backlog milestone Oct 5, 2022
alxhub
alxhub approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

alxhub
alxhub approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from atscott October 5, 2022 20:52
jessicajaniuk
jessicajaniuk approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 5, 2022
@crisbeto crisbeto removed the action: presubmit The PR is in need of a google3 presubmit label Oct 6, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit db28bad.

@TrevorKarjanis TrevorKarjanis mentioned this pull request Oct 28, 2022
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: major This PR is targeted for the next major release
Projects
None yet
Milestone
v15 feature freeze blockers
Development

Successfully merging this pull request may close these issues.

Proposal: Need ability to add directives to host elements in component declaration.
3 participants
@crisbeto @jessicajaniuk @alxhub