Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ngcc): support alternate wrapper function layout for UMD #43879

Closed
wants to merge 1 commit into from
Closed

fix(ngcc): support alternate wrapper function layout for UMD #43879

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Oct 18, 2021 •
edited
Loading

Recently rollup, used by ng-packagr, changed the position of parentheses
around its generated UMD wrapper functions.

This commit ensures that ngcc can handle both.

Fixes #43870

@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release comp: ngcc labels Oct 18, 2021
@ngbot ngbot bot modified the milestone: Backlog Oct 18, 2021
@google-cla google-cla bot added the cla: yes label Oct 18, 2021
@petebacondarwin
fix(ngcc): support alternate wrapper function layout for UMD
1c6e905 
Recently rollup, used by ng-packagr, changed the position of parentheses
around its generated UMD wrapper functions.

This commit ensures that ngcc can handle both.

Fixes angular#43870
@petebacondarwin petebacondarwin force-pushed the ngcc-umd-rollup-changes-issue-43870 branch from 5aa8bca to 1c6e905 Compare October 18, 2021 16:29
@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 18, 2021
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit ec8a565.

AndrewKushnir pushed a commit that referenced this pull request Oct 18, 2021
@petebacondarwin @AndrewKushnir
fix(ngcc): support alternate wrapper function layout for UMD (#43879)
cab21ce 
Recently rollup, used by ng-packagr, changed the position of parentheses
around its generated UMD wrapper functions.

This commit ensures that ngcc can handle both.

Fixes #43870

PR Close #43879
AndrewKushnir pushed a commit that referenced this pull request Oct 18, 2021
@petebacondarwin @AndrewKushnir
fix(ngcc): support alternate wrapper function layout for UMD (#43879)
c882b9f 
Recently rollup, used by ng-packagr, changed the position of parentheses
around its generated UMD wrapper functions.

This commit ensures that ngcc can handle both.

Fixes #43870

PR Close #43879
gkalpak added a commit to gkalpak/angular that referenced this pull request Oct 23, 2021
@gkalpak
fix(ngcc): support alternate UMD layout when adding new imports
c7401b5 
In angular#43879, `UmdReflectionHost` was updated to deal with the new UMD
format used by Rollup, where the parenthesis is around thw wrapper
function and not the wrapper function call.
For reference, this caused failures in the `ngcc-validation` repo
([example 1][1], [example 2][2]).

This commit updates `UmdRenderingFormatter` to also handle both UMD
formats. In order to validate the change, this commit also updates the
`UmdRenderingFormatter` tests to run against both UMD formats.

[1]: https://circleci.com/gh/angular/ngcc-validation/65916
[2]: https://circleci.com/gh/angular/ngcc-validation/65758
gkalpak added a commit to gkalpak/angular that referenced this pull request Oct 23, 2021
@gkalpak
fix(ngcc): support alternate UMD layout when adding new imports
da9b1de 
In angular#43879, `UmdReflectionHost` was updated to deal with the new UMD
format used by Rollup, where the parenthesis is around the wrapper
function and not the wrapper function call.
For reference, this caused failures in the `ngcc-validation` repo
([example 1][1], [example 2][2]).

This commit updates `UmdRenderingFormatter` to also handle both UMD
formats. In order to validate the change, this commit also updates the
`UmdRenderingFormatter` tests to run against both UMD formats.

[1]: https://circleci.com/gh/angular/ngcc-validation/65916
[2]: https://circleci.com/gh/angular/ngcc-validation/65758
@gkalpak gkalpak mentioned this pull request Oct 23, 2021
Closed
gkalpak added a commit to gkalpak/angular that referenced this pull request Oct 25, 2021
@gkalpak
fix(ngcc): support alternate UMD layout when adding new imports
61931ae 
In angular#43879, `UmdReflectionHost` was updated to deal with the new UMD
format used by Rollup, where the parenthesis is around the wrapper
function and not the wrapper function call.
For reference, this caused failures in the `ngcc-validation` repo
([example 1][1], [example 2][2]).

This commit updates `UmdRenderingFormatter` to also handle both UMD
formats. In order to validate the change, this commit also updates the
`UmdRenderingFormatter` tests to run against both UMD formats.

[1]: https://circleci.com/gh/angular/ngcc-validation/65916
[2]: https://circleci.com/gh/angular/ngcc-validation/65758
jessicajaniuk pushed a commit that referenced this pull request Oct 25, 2021
@gkalpak @thePunderWoman
fix(ngcc): support alternate UMD layout when adding new imports (#43931)
7c5d642 
In #43879, `UmdReflectionHost` was updated to deal with the new UMD
format used by Rollup, where the parenthesis is around the wrapper
function and not the wrapper function call.
For reference, this caused failures in the `ngcc-validation` repo
([example 1][1], [example 2][2]).

This commit updates `UmdRenderingFormatter` to also handle both UMD
formats. In order to validate the change, this commit also updates the
`UmdRenderingFormatter` tests to run against both UMD formats.

[1]: https://circleci.com/gh/angular/ngcc-validation/65916
[2]: https://circleci.com/gh/angular/ngcc-validation/65758

PR Close #43931
jessicajaniuk pushed a commit that referenced this pull request Oct 25, 2021
@gkalpak @thePunderWoman
fix(ngcc): support alternate UMD layout when adding new imports (#43931)
6e37c93 
In #43879, `UmdReflectionHost` was updated to deal with the new UMD
format used by Rollup, where the parenthesis is around the wrapper
function and not the wrapper function call.
For reference, this caused failures in the `ngcc-validation` repo
([example 1][1], [example 2][2]).

This commit updates `UmdRenderingFormatter` to also handle both UMD
formats. In order to validate the change, this commit also updates the
`UmdRenderingFormatter` tests to run against both UMD formats.

[1]: https://circleci.com/gh/angular/ngcc-validation/65916
[2]: https://circleci.com/gh/angular/ngcc-validation/65758

PR Close #43931
jessicajaniuk pushed a commit that referenced this pull request Oct 25, 2021
@gkalpak @thePunderWoman
fix(ngcc): support alternate UMD layout when adding new imports (#43931)
067ae54 
In #43879, `UmdReflectionHost` was updated to deal with the new UMD
format used by Rollup, where the parenthesis is around the wrapper
function and not the wrapper function call.
For reference, this caused failures in the `ngcc-validation` repo
([example 1][1], [example 2][2]).

This commit updates `UmdRenderingFormatter` to also handle both UMD
formats. In order to validate the change, this commit also updates the
`UmdRenderingFormatter` tests to run against both UMD formats.

[1]: https://circleci.com/gh/angular/ngcc-validation/65916
[2]: https://circleci.com/gh/angular/ngcc-validation/65758

PR Close #43931
This was referenced Nov 1, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Nov 1, 2021
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 18, 2021
Serginho pushed a commit to TuLotero/angular that referenced this pull request Jan 20, 2022
@petebacondarwin @Serginho
fix(ngcc): support alternate wrapper function layout for UMD (angular…
004bbea 
…#43879)

Recently rollup, used by ng-packagr, changed the position of parentheses
around its generated UMD wrapper functions.

This commit ensures that ngcc can handle both.

Fixes angular#43870

PR Close angular#43879
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

NGCC fails to sniff module type for some UMD modules
3 participants
@petebacondarwin @AndrewKushnir @JoostK