Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): allow tsc-wrapped to be compile with TypeScript 2.0 #11086

Merged
merged 1 commit into from
Aug 26, 2016

Conversation

chuckjaz
Copy link
Contributor

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix

What is the current behavior? (You can also link to an open issue here)

tsc-watch CompilerHost implementations don't implement the newly required method getDirectories().

What is the new behavior?

Implemented getDirectories() in DelegatingCompilerHost to allow using compiling tsc-watch with TypeScript 2.0's .d.ts

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@hansl
Copy link
Contributor

hansl commented Aug 25, 2016

LGTM. Can confirm this fixes our build problems with TS2 Beta. 👍

@chuckjaz chuckjaz added the action: merge The PR is ready for merge by the caretaker label Aug 25, 2016
@vicb vicb merged commit fc2fe00 into angular:master Aug 26, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants