This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Scope event changes #914

Merged

vojtajina merged 2 commits into angular:master from vojtajina:scope-event

May 18, 2012

Contributor

vojtajina commented Apr 27, 2012

Things to consider:

e.stopPropagation() during $broadcast stops propagation only for given branch (it does depth-first traverse).
e.stopPropagation() if not allowed throws exception ( noop ?)
do we really want options object rather than just third boolean attribute (allowToStopPropagation)
by default stopPropagation is allowed

vojtajina added 2 commits

May 17, 2012 15:47


          refactor(scope.$emit): rename event.cancel() to event.stopPropagation()

91db992

Breaks event.cancel() is event.stopPropagation()


          feat(scope): add event.preventDefault() and event.defaultPrevented

84542d2

vojtajina merged commit 84542d2 into angular:master

just-boris mentioned this pull request

feat($rootScope): implement event.stopPropagation() for $broadcast-ed events #12672

Open

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet