This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
min/max validator fixes to number and date inputs #8913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM for numbers (but I believe min/max also has a meaning for various date inputs too) |
|
Thx. I'm changing the commit message of the first commit to reflect that. |
matsko
force-pushed
the
pr_2404
branch
2 times, most recently
from
d6fa37f to
546ffaf
Compare
…nge for number inputs As of this fix if the max or min value is changed via scope or by another ngModel then it will trigger the model containing the min/max attributes to revalidate itself. Closes angular#2404
…t types With this fix ngModel will treat ngMin as a min error and ngMax as a max error. This also means that when either of these two values is changed then ngModel will revaliate itself.
…nge for date inputs Closes angular#6755
Due to the nature of how date objects are rendered when JSON.stringify is called, the resulting string contains two sets of quotes surrounding it. This commit fixes that issue. Closes angular#6755
matsko
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2404
Closes #6755