This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
docs($location): add note about breaking anchor links #8660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained in angular#4608, $location injection can cause issues by inserting a / after a hash in the url, if html5mode is not enabled. Possible fix is in angular#8508.
|
I think the contents of the docs change should link to the relevant GitHub issues for context. If a fix for this is going to land soon, it may be better not to add this note to the docs only to remove it. |
|
There's no CL fixing this currently, but I think we should treat it as a bug rather than a feature, there's no real reason why we need to get this wrong |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
|
Agree with @caitp - we should rather fix the underlying bug instead of adding warnings to the docs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #4608, $location injection can cause issues by inserting a / after a hash in the url, if html5mode is not enabled. Possible fix is in #8508.