refactor(externs): Move Closure Externs back to Closure code repository. #5906
Conversation
While Closure Compiler generally recommends to maintain the externs for projects together with their source, this has not worked well for AngularJS: - Changes to externs must be tested; they can break clients. AngularJS has no testing infrastructure for this. - Changes mostly come from users inside of Google and are much more easily submitted together with the code using them within Google's repository. This change deletes the externs here and adds a README.closure.md to document the change. They will be added back to Closure Compiler in a separate submit.
|
As discussed with @IgorMinar, this is moving the externs back to the Closure Compiler code repository. |
|
See also #5907 for the v1.0.x branch. |
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
ghost
assigned 
|
@mprobst can you please sign the CLA with your google email address? it's going to make future interaction with @mary-poppins much easier :) |
|
I just realized that we can't merge this in until the internal CL is submitted, otherwise we'd break stuff. I'm going to hold off on this PR. it looks great otherwise |
|
THANK GOD! |
|
Yeah, sometimes you just have to make those mistakes to learn ;-) On Mittwoch, 22. Januar 2014 21:57:40, Wes Alvaro notifications@github.com THANK GOD! — |
While Closure Compiler generally recommends to maintain the externs for
projects together with their source, this has not worked well for
AngularJS:
has no testing infrastructure for this.
easily submitted together with the code using them within Google's
repository.
This change deletes the externs here and adds a README.closure.md to
document the change. They will be added back to Closure Compiler in a
separate submit.