Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngHideShow): Add a list of falsy values #5762

Closed
wants to merge 1 commit into from
Closed

docs(ngHideShow): Add a list of falsy values #5762

wants to merge 1 commit into from

Conversation

Foxandxss
Copy link
Member

This PR closes #3436

This issue has been a focus of problems for some users and we discussed it on the IRC that it should be at least documented.

I am not familiarized with this style of documentation so I hope it has the right style.

This PR closes #3436

This issue has been a focus of problems for some users and we discussed it on the IRC that it should be at least documented.

I am not familiarized with this style of documentation so I hope it has the right style.
@cironunes
Copy link
Member

+1

@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@Foxandxss
Copy link
Member Author

Sorry Igor, I thought that the CLA was for code changes (not docs) but I just signed it ;)

@IgorMinar
Copy link
Contributor

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@caitp caitp closed this in e591ddc Jan 15, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
This issue has been a focus of problems for some users and we discussed it on the IRC that it should
be at least documented.

~Amended the style to use bootstrap notes, I think overall it looks better and catches the eyes more
easily. However there are no anchor links to these, if these are necessary they can be added later.

Closes angular#3436
Closes angular#5762
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
This issue has been a focus of problems for some users and we discussed it on the IRC that it should
be at least documented.

~Amended the style to use bootstrap notes, I think overall it looks better and catches the eyes more
easily. However there are no anchor links to these, if these are necessary they can be added later.

Closes angular#3436
Closes angular#5762
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False boolean values found when using ng-show/ng-hide
3 participants