Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/concepts): removed div-clear-tags breaking the formatting #3974

Closed
wants to merge 1 commit into from

Conversation

Silwing
Copy link
Contributor

@Silwing Silwing commented Sep 11, 2013

The concepts page of the docs (http://docs.angularjs.org/guide/concepts) is half unreadable due to formatting not being parsed properly.

It can be solved by removing <div class="clear"></div> from the concepts.ng, which I did in this PR.

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@Silwing
Copy link
Contributor Author

Silwing commented Sep 11, 2013

My real name is Randi Katrine Hillerøe and I just signed the CLA a few hours ago.

@petebacondarwin
Copy link
Contributor

Thanks @Silwing - I just had to tweak the commit message slightly - we don't use past tense.

@Silwing
Copy link
Contributor Author

Silwing commented Sep 11, 2013

Ah, I'm still learning this whole git pull request thing :) I fixed the tense in my commit but apparantly I needed to fix it separately for the PR as well.

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Sep 25, 2013
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants