This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngMobile): trigger ngClick event on element #3219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this patch, people can bind to the 'ngClick' event in directives so that they can run code on the non native mobile tap/click event which is controlled by the click directive from the ngMobile module. Fixes angular#3218
|
The PR is missing tests yet. However, I first wanted to get a review if it's going to get merged, if tests follow. |
|
However jquery-mobile also introduces a new name for the event (they call it |
|
This LGTM, since we have an expressed need for it in #3218. Definitely need some tests, though. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch, people can bind to the 'ngClick'
event in directives so that they can run code
on the non native mobile tap/click event which
is controlled by the click directive from the
ngMobile module.
Fixes #3218