Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(noConflict): resolve global JSONP conflicts and window.angular cannibalization #2893

Closed
wants to merge 1 commit into from

Conversation

mbrevoort
Copy link

Eliminate window.angular.callbacks and use random callback handles on window to eliminate multiple angular version conflicts.

Also sure to start with an empty window.angular object rather than polluting existing window.angular. Prior, even though a reference to window.angular was kept in a local variable _angular, angular would load itself onto window.angular anyway polluting _angular in the process.

This is a follow-up to this rejected pull request: #2731 and this thread on the mailing list: https://groups.google.com/forum/?fromgroups#!searchin/angular/noConflict/angular/G8xPyD1F8d0/7m96EbK2l1oJ

Thanks!
Mike

…nnibalization

Eliminate angular.callbacks and use random callback handles on window to eliminate multiple angular version conflicts, and be sure to start with an empty window.angular object rather than polluting existing window.angular
@mhevery
Copy link
Contributor

mhevery commented Jun 7, 2013

Removed broken no-conflict feature completely. this PR no longer relavant.

@mhevery mhevery closed this Jun 7, 2013
@mbrevoort
Copy link
Author

@mhevery that is very disappointing. Why? We desperately need noConflict functionality at Pearson in the near term.

@thorn0
Copy link
Contributor

thorn0 commented Aug 6, 2013

It's really disappointing. I'm going to develop widgets that are to be embedded into a big legacy web app. What if some other 3rd party widget uses Angular too?

@petebacondarwin
Copy link
Contributor

Hi guys. Don't be too disappointed.

It is not that noConflict is a bad thing. It is just that the current noConflict bits in angular are not good, broken and too hackish.

What we need is a really solid implementation across the board that works cleanly for JSONP, etc.
If the right PR is found then it will be merged.
If there is really strong commercial interest (which there appears to be from the Pearson crowd at least) I think we should try to arrange an online meeting to go over the best strategy to solve this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants