This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(noConflict): resolve global JSONP conflicts and window.angular cannibalization #2893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate
window.angular.callbacks
and use random callback handles onwindow
to eliminate multiple angular version conflicts.Also sure to start with an empty
window.angular
object rather than polluting existingwindow.angular
. Prior, even though a reference towindow.angular
was kept in a local variable_angular
, angular would load itself ontowindow.angular
anyway polluting_angular
in the process.This is a follow-up to this rejected pull request: #2731 and this thread on the mailing list: https://groups.google.com/forum/?fromgroups#!searchin/angular/noConflict/angular/G8xPyD1F8d0/7m96EbK2l1oJ
Thanks!
Mike