Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Issue 167 repeater inputs #200

Closed
wants to merge 5 commits into from

Conversation

esprehn
Copy link
Contributor

@esprehn esprehn commented Dec 22, 2010

Known issue:

Bindings on the element (that are not a descendent) are not matched by binding(). This is possible, but requires a bunch of jQuery work that would probably be a little slow. How important is that feature?

@esprehn
Copy link
Contributor Author

esprehn commented Dec 23, 2010

I discussed this with Igor and we think maybe we should hold off on this change and go a different route (closer to Shyam's original proposal).

Propposed Change: Support binding and attribute selection in jQuery expressions:

We need to decide on the syntax. Technically XPath would solve all these issues, but jQuery dropped support for XPath a long time ago. Maybe:
repeater('...').row(0, ['a.productLink -> @href', '{{productName}}'])
and we remove binding() and people just use
element('{{binding}}').html() // get the binding value
or
element('a [href*={{username}}] -> @href').text() // get the attribute value

What do you think? Should we go forward with this change? Should we extend the jQuery syntax? I'm not a huge fan of that since it diverges so badly from CSS3 syntax, but it does solve the issue of how repeater().row() works. Often you want to select a bunch of things that are not really bindings from a repeater too.

@IgorMinar
Copy link
Contributor

I'm not keen on the diversion from the css3 syntax, but I think this proposal is the best we have so far. Misko?

@btford
Copy link
Contributor

btford commented Jul 30, 2012

This looks stale; can we close it?

@mhevery
Copy link
Contributor

mhevery commented Aug 28, 2012

closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants