This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(grunt-utils): correctly detect java 32bit support #16605
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix, related to #4595. All flags after
-version
are ignored. This is causing a false positive in the test for 32bit support. Moving-d32
flag before-version
fixes the issue.What is the current behavior? (You can also link to an open issue here)
When using java 10, the grunt "minall" task fails:
What is the new behavior (if this is a feature change)?
Works with java 10
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: