fix(form): set $submitted to true on child forms when parent is submitted #11023

ckniffen · 2015-02-10T19:02:45Z

FormController will now call $setSubmitted on its child forms when it is submitted.

googlebot · 2015-02-10T19:02:46Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

Narretz · 2015-03-01T16:01:49Z

src/ng/directive/form.js

@@ -276,10 +276,17 @@ function FormController(element, attrs, $scope, $animate, $interpolate) {
   * @description
   * Sets the form to its submitted state.
   */
-  form.$setSubmitted = function() {
+  form.$setSubmitted = function(reverse) {


reverse is not really a good name. How about setOnChild or something similar?

googlebot · 2015-03-05T20:17:06Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

ckniffen · 2015-03-05T20:24:02Z

@googlebot I am indeed the author.

googlebot · 2015-05-26T19:09:59Z

CLAs look good, thanks!

scottty881 · 2015-05-28T17:35:11Z

+1

ckniffen · 2015-09-13T16:57:06Z

@Narretz what is the status of this issue? Is there anything I can do to move this along?

kentcdodds · 2015-09-14T15:07:38Z

👍 any chance this could be made available in 1.3.x? Or at least 1.4.x (rather than just 1.5.x) :-)

benoror · 2015-09-14T15:18:10Z

👍

Narretz · 2015-09-14T19:54:45Z

1.4.x yes, 1.3.x no. I just wonder if it can be considered a breaking change

ckniffen · 2015-09-14T20:33:13Z

One possible middle ground would be exposing the array of controls. That way they can be iterated over in a third party plugin.

Narretz · 2015-09-18T18:40:19Z

test/ng/directive/formSpec.js

@@ -523,6 +523,22 @@ describe('form', function() {
      expect(parent.$submitted).toBeTruthy();
    });

+    it('should set $submitted equal to true on child forms when parent is submitted', function() {
+      doc = jqLite(
+          '<ng:form name="parent">' +


Can you please use ng-form et. al.? I think these tests are very old, that's why they use ng:form.

@Narretz Should I update all the tests in this file to use ng-form?

ckniffen · 2015-09-23T02:11:19Z

@gkalpak I looked into the the docs for the similar methods on a FormController. The current documentation for $setSubmitted says nothing about propagating. I think there is some confusion, at least for me, around the reasoning for why each method propagates the way it does.

$setDirty - goes up
$setSubmitted - goes up
$setPristine - goes down
$setUntouched - goes down

To me $setDirty makes sense to propagate up because if one child control or form is dirty then the parents are too. $setSubmitted has a similar use case as to $setPristine and $setUntouched because often times a form is made up of many nested forms which submit as one.

One alternative to making this change as I have mentioned above is to expose the controls array as $controls so that consumers of this api can write directives that are able to safely iterate over a FormController's child controls. Such a change could be leveraged by formly for example.

…tted. Closes angular#10071

gkalpak · 2015-09-25T08:43:59Z

@ckniffen, I wonder myself why $setSubmitted propagates the way it does (I don't find it intuitive, but I rarely make use of it anyway). I would be open to changing its behaviour, but it will be a breaking change so it has to be made before 1.5.0 (if at all).
Feel free to open an issue about it and see what people think.

Exposing $controls should definitely be helpful in certain scenarios, but could also be abused leading to weird and hard to debug bugs. I'm undecided about this, but would happily review a PR :)

Narretz · 2015-09-25T09:07:54Z

There's no (big) rush to get this in. We'll have a few 1.5.0-beta.x releases before the 1.5.0 release (which should be the first not to contain any breaking changes).

pbrain19 · 2017-01-11T19:31:06Z

will we be able to merge this before Obama leaves office?

Narretz · 2017-03-06T12:21:46Z

Let's continue discussion in #15778. I'm confident we'll resolve this before Trump is impeached.

googlebot added the cla: no label Feb 10, 2015

Narretz reviewed Mar 1, 2015
View reviewed changes

Narretz added this to the Backlog milestone Mar 1, 2015

Narretz added type: bug component: forms frequency: low needs: work labels Mar 1, 2015

Narretz self-assigned this Mar 1, 2015

ckniffen force-pushed the nested-form-submitted branch 2 times, most recently from aa1e60e to 5d39b2e Compare March 5, 2015 20:19

ckniffen force-pushed the nested-form-submitted branch from 5d39b2e to 47afd65 Compare May 26, 2015 19:09

googlebot added cla: yes and removed cla: no labels May 26, 2015

ckniffen force-pushed the nested-form-submitted branch 2 times, most recently from 8ae27a5 to e549f2d Compare September 13, 2015 17:20

kentcdodds mentioned this pull request Sep 14, 2015

Validation on Submit not being invoked in a nested form formly-js/angular-formly#465

Open

Narretz reviewed Sep 18, 2015
View reviewed changes

ckniffen force-pushed the nested-form-submitted branch from e549f2d to 9879ede Compare September 23, 2015 02:14

fix(form): set $submitted to true on child forms when parent is submi…

3d0602f

…tted. Closes angular#10071

ckniffen force-pushed the nested-form-submitted branch from 9879ede to 3d0602f Compare September 23, 2015 02:24

benoror mentioned this pull request Oct 28, 2015

resetModel doesn't work for nested forms formly-js/angular-formly#528

Closed

Narretz force-pushed the master branch from 70049ae to b77e14b Compare January 16, 2016 21:59

gkalpak mentioned this pull request Oct 27, 2016

Form submit preventing #15319

Closed

gkalpak added needs: breaking change needs: investigation labels Jan 11, 2017

gkalpak modified the milestones: 1.7.0, Backlog Jan 11, 2017

Narretz closed this Mar 6, 2017

Narretz mentioned this pull request Mar 23, 2017

Fix: set $submitted on child forms when form is submitted #15778

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(form): set $submitted to true on child forms when parent is submitted #11023

fix(form): set $submitted to true on child forms when parent is submitted #11023

ckniffen commented Feb 10, 2015

googlebot commented Feb 10, 2015

Narretz Mar 1, 2015

googlebot commented Mar 5, 2015

ckniffen commented Mar 5, 2015

googlebot commented May 26, 2015

scottty881 commented May 28, 2015

ckniffen commented Sep 13, 2015

kentcdodds commented Sep 14, 2015

benoror commented Sep 14, 2015

Narretz commented Sep 14, 2015

ckniffen commented Sep 14, 2015

Narretz Sep 18, 2015

ckniffen Sep 23, 2015

ckniffen commented Sep 23, 2015

gkalpak commented Sep 25, 2015

Narretz commented Sep 25, 2015

pbrain19 commented Jan 11, 2017

Narretz commented Mar 6, 2017

fix(form): set $submitted to true on child forms when parent is submitted #11023

fix(form): set $submitted to true on child forms when parent is submitted #11023

Conversation

ckniffen commented Feb 10, 2015

googlebot commented Feb 10, 2015

Narretz Mar 1, 2015

Choose a reason for hiding this comment

googlebot commented Mar 5, 2015

ckniffen commented Mar 5, 2015

googlebot commented May 26, 2015

scottty881 commented May 28, 2015

ckniffen commented Sep 13, 2015

kentcdodds commented Sep 14, 2015

benoror commented Sep 14, 2015

Narretz commented Sep 14, 2015

ckniffen commented Sep 14, 2015

Narretz Sep 18, 2015

Choose a reason for hiding this comment

ckniffen Sep 23, 2015

Choose a reason for hiding this comment

ckniffen commented Sep 23, 2015

gkalpak commented Sep 25, 2015

Narretz commented Sep 25, 2015

pbrain19 commented Jan 11, 2017

Narretz commented Mar 6, 2017