IE8 9: a link route error(angular 1.2.17 1.2.18)

[dolymood]

if my angular version is 1.2.18
base element, href is '/n/b/'
my a link's href is 'c/xx'
so i click this link then

• if the current location.href is 'http://www.x.com/n/b/#!/'

  location.href should be 'http://www.x.com/n/b/#!/c/xx' but the result is error, so i debug this and find that in line 9714 the "absHref" is 'http://www.x.com/n/b/#!//c/xx'

• if the current location.href is 'http://www.x.com/n/b/#!/c/yy'

  location.href should be 'http://www.x.com/n/b/#!/c/xx' but the result is error, so i debug this and find that in line 9714 the "absHref" is 'http://www.x.com/n/b/#!/c/yy/c/xx'

Please check it.

[acostaf]

+1

[alexsaare]

+1

[rodyhaddad]

Can you confirm that this wasn't an issue in 1.2.17?

Also, a plunkr that reproduces the problem would help a lot

[caitp]

@rodyhaddad this is a confirmed issue, although it hasn't been narrowed down to a specific commit. It was most likely my changes which were supposed to make relative route resolution work better in legacy browsers.

It's hard to sort out where the problem started happening, because I do remember this working when those were checked in, but without a legacy IE browser to use, it's a bit hard to sort out.

[acostaf]

Hi @rodyhaddad

Yeah that issue was introduced on 1.2.17 also exist in 1.2.18 and 1.3 beta 13 I already opened another ticket #7892 (comment) where you may find the repro for this issue, however you repro this just going to the route doc page and try to use the demo in there

[winsontam]

i think this is the issue i created at #8172 too.
i have made a pinkr
http://plnkr.co/edit/mJdoeVo5Q2qiLJXyjR9O?p=preview
please test it in IE8/9.

[caitp]

This should also be fixed by #8492 --- but I'm moving it to the next milestone in case the revert doesn't land today

[winsontam]

Can it put to 1.2.x version as well?

[wjamro]

@winsontam +1

[tbosch]

Hi,
I could not reproduce this problem in angular 1.2.17 or 1.2.18, see this plunker:
http://plnkr.co/edit/yfjbfKtg7Tdn1arniLec?p=preview

Press the links and then look into the browser console.

Closing this, please comment if you have a plunker/jsfiddle to reproduce this.

[tbosch]

Ah, IE9 does not open plunker.
Here is a jsfiddle and I tested it against IE9 on Windows 7: http://jsfiddle.net/b7qkbj39/show/

[tbosch]

@acostaf Your link points to this same issue. Do you still have the reproduction case?

[acostaf]

@tbosch this is still broken and this may be the easiest bug to reproduce, open https://docs.angularjs.org/#!/api/ngRoute/service/$route on IE9 then try to run the sample at the end of the page pressing the books button.

[tbosch]

@acostaf I can see the bug reported at #8172, namely that links add up in html5mode in older browsers. I will push a fix for this in a minute (see #8851). Does that other bug include this issue?

[acostaf]

@tbosch yes It does