Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ng-animate CSS class gets stuck on element w/existing CSS transition #7766

Closed
danxshap opened this issue Jun 10, 2014 · 5 comments
Closed

ng-animate CSS class gets stuck on element w/existing CSS transition #7766

danxshap opened this issue Jun 10, 2014 · 5 comments
Assignees
@matsko
Labels
component: ngAnimate type: bug
Milestone
1.3.0-beta.15

Comments

@danxshap
Copy link

I'm using both ngClass & ngAnimate with an existing CSS transition, and the result/problem is that the ng-animate class does not get removed from the element as it should.

I'm not trying to use Angular animations at all for this element, but I need to have ngAnimate as a dependency because I'm using it for other elements on the page.

See reproduction here: http://plnkr.co/edit/IcesSJdZFVFNO2Jvd8Pd?p=preview

Click the button & immediately hover away. In 2 seconds it's supposed to disappear but it doesn't because it has both the "ng-animate" and "ng-hide" classes. Strangely, if you then/later hover over it, it disappears.

This wasn't happening in v1.2.0 which I just upgraded from, but I realize that's pretty old.
@danxshap danxshap mentioned this issue Jun 10, 2014
Closed
@matsko matsko self-assigned this Jun 10, 2014
@matsko
Copy link
Contributor

matsko commented Jun 10, 2014

Great. I will look into this one tomorrow.

@caitp caitp added this to the 1.3.0-beta.12 milestone Jun 10, 2014
@matsko
Copy link
Contributor

matsko commented Jun 10, 2014

Fixed: http://plnkr.co/edit/gJXo8RlzV4ZkjFSua9a0?p=preview

matsko added a commit to matsko/angular.js that referenced this issue Jun 10, 2014
@matsko
fix($animate): ensure that parallel class-based animations are all ev…
749610c 
…entually closed

When multiple classes are added/removed in parallel then $animate only closes off the
last animation when the fallback timer has expired. Now all animations are closed off.

Fixes angular#7766
@matsko
Copy link
Contributor

matsko commented Jun 10, 2014

OK and now we have a PR that is awaiting to be merged.

@matsko matsko mentioned this issue Jun 10, 2014
Closed
@airato airato mentioned this issue Jun 11, 2014
Closed
@ashclarke
Copy link

I experienced this too - I thought it was due to me not setting the classes/css right. Glad to see a fix is in! 👍

matsko added a commit to matsko/angular.js that referenced this issue Jul 1, 2014
@matsko
fix($animate): ensure that parallel class-based animations are all ev…
241f9a9 
…entually closed

When multiple classes are added/removed in parallel then $animate only closes off the
last animation when the fallback timer has expired. Now all animations are closed off.

Fixes angular#7766
@matsko matsko closed this as completed in f07af61 Jul 1, 2014
@mattslocum
Copy link

Is this going to be merged into 1.2.x too?
I would love to see it in 1.2.21

ckknight pushed a commit to ckknight/angular.js that referenced this issue Jul 16, 2014
@matsko
fix($animate): ensure that parallel class-based animations are all ev…
3717c5b 
…entually closed

When multiple classes are added/removed in parallel then $animate only closes off the
last animation when the fallback timer has expired. Now all animations are closed off.

Fixes angular#7766
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matsko matsko

Labels
component: ngAnimate type: bug
Projects
None yet
Milestone
1.3.0-beta.15
7 participants
@matsko @ashclarke @danxshap @rodyhaddad @mattslocum @caitp @caguillen214