Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

1.2.0-rc.3 ngAnimate is really buggy with ng-class #4463

Closed
nosideeffects opened this issue Oct 16, 2013 · 3 comments · Fixed by #4573
Closed

1.2.0-rc.3 ngAnimate is really buggy with ng-class #4463

nosideeffects opened this issue Oct 16, 2013 · 3 comments · Fixed by #4573
Assignees
@matsko
Milestone
1.2.0 - timely-de...

Comments

@nosideeffects
Copy link
Contributor

If you use ng-class with ngAnimate, to say animate left or right conditionally, ngAnimate 1.2.0-rc.3 often skips the animation entirely, whereas it seemingly always executes properly in 1.2.0-rc.2.

Plunkr for 1.2.0-rc.3: http://plnkr.co/edit/3VACcBG8GTyav5FNYNHo?p=preview

Just revert back to 1.2.0-rc.2 in the above example and see the buggy behavior disappear.
@matsko
Copy link
Contributor

matsko commented Oct 17, 2013

So yes this is a bug. What's going on is ng-class is competing with ng-show and it only shows up when the direction is set or changes. This is why it shows up on the first value. There's another issue open right now that is present due to this bug and I'm working on a fix.

@ghost ghost assigned matsko Oct 17, 2013
@matsko
Copy link
Contributor

matsko commented Oct 17, 2013

Fixed: http://plnkr.co/edit/UDyTDuNbpIRYxkgvzxGe?p=preview.

Submitting a PR soon.

@nosideeffects
Copy link
Contributor Author

Awesome work! Thanks for the hastened fix!

@matsko matsko mentioned this issue Oct 18, 2013
Closed
matsko added a commit to matsko/angular.js that referenced this issue Oct 22, 2013
@matsko
fix($animate): only cancel class-based animations if the follow-up cl…
d0ed528 
…ass contains CSS transition/keyframe animation code

Closes angular#4463
Closes angular#3784
@matsko matsko mentioned this issue Oct 22, 2013
Merged
@matsko matsko closed this as completed in f5289fe Oct 23, 2013
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
@matsko @jamesdaily
fix($animate): only cancel class-based animations if the follow-up cl…
3bb79d2 
…ass contains CSS transition/keyframe animation code

Closes angular#4463
Closes angular#3784
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
@matsko @jamesdaily
fix($animate): only cancel class-based animations if the follow-up cl…
41a2c32 
…ass contains CSS transition/keyframe animation code

Closes angular#4463
Closes angular#3784
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matsko matsko

Labels
None yet
Projects
None yet
Milestone
1.2.0 - timely-delivery
2 participants
@matsko @nosideeffects