refactor(core): use native String.prototype.trim if available

angular · Jul 3, 2013 · 22b9b47 · 22b9b47
1 parent 5349b20
commit 22b9b47
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/src/Angular.js b/src/Angular.js
@@ -436,9 +436,20 @@ function isBoolean(value) {
 }
 
 
-function trim(value) {
-  return isString(value) ? value.replace(/^\s*/, '').replace(/\s*$/, '') : value;
-}
+var trim = (function() {
+  // native trim is way faster: http://jsperf.com/angular-trim-test
+  // but IE doesn't have it... :-(
+  // TODO: we should move this into IE/ES5 polyfill
+  if (!String.prototype.trim) {
+    return function(value) {
+      return isString(value) ? value.replace(/^\s*/, '').replace(/\s*$/, '') : value;
+    };
+  }
+  return function(value) {
+    return isString(value) ? value.trim() : value;
+  };
+})();
+
 
 /**
  * @ngdoc function