Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ngtools/webpack: honor tsconfig#angularCompilerOptions.entryModule before trying to resolveEntryModuleFromMain() #4013

Merged
merged 2 commits into from
Jan 15, 2017

Conversation

tsabirgaliev
Copy link
Contributor

No description provided.

…e` before falling back to `resolveEntryModuleFromMain()`
@tsabirgaliev tsabirgaliev changed the title @ngtools/webpack: honor tsconfig#angularCompilerOptions.entryModule before trying to resolveEntryModuleFromMain() @ngtools/webpack: honor tsconfig#angularCompilerOptions.entryModule before trying to resolveEntryModuleFromMain() Jan 14, 2017
@tsabirgaliev tsabirgaliev force-pushed the fallback-to-resolve-from-main branch from b061bb9 to 3893653 Compare January 14, 2017 20:25
@tsabirgaliev tsabirgaliev force-pushed the fallback-to-resolve-from-main branch from 3893653 to f4b8f51 Compare January 14, 2017 20:33
@hansl
Copy link
Contributor

hansl commented Jan 15, 2017

LGTM, thanks!

@hansl hansl merged commit c9ac263 into angular:master Jan 15, 2017
@tsabirgaliev
Copy link
Contributor Author

@hansl I have a patch to also expose entryModule in aangular-cli.json. If this going in right direction, I can make a PR

MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants