Load zone.js long-stack-trace in debug mode #3999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[dist/long-stack-trace-zone.min.js](https://github.com/angular/zone.js/blob/master/dist/long-stack-trace-zone.min.js) should be loaded in the development environment to give more meaningful stack traces. Without this script, only the last VM turn is logged. When this script is loaded the stack will contain all VM turns from the point the async operation was initiated. fixes #2233
hansl
reviewed
Jan 14, 2017
| @@ -7,6 +7,8 @@ import { AppModule } from './app/app.module'; | |||
|
|
|||
| if (environment.production) { | |||
| enableProdMode(); | |||
| } else { | |||
| require('zone.js/dist/long-stack-trace-zone'); | |||
There was a problem hiding this comment.
Unfortunately this is not the right way to go, as webpack will ALWAYS include that code in your bundle, even in production.
|
I see. Can you point me to a better place? |
|
What do you think about this? |
|
I think the right place for this code would be as a script tag, after polyfills, if the target is dev. We're already refactoring that section of the code (poly fills), I'll ensure that's being done as well. |
|
Excellent! 👍 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dist/long-stack-trace-zone.min.js should be loaded in the development environment to give more meaningful stack traces.
Without this script, only the last VM turn is logged. When this script is loaded the stack will contain all VM turns from the point the async operation was initiated.
fixes #2233