chore(completion) - generate shell script in a much more automated way #3981

catull · 2017-01-13T03:25:35Z

All the options are taken straight from the commands, aliases as well.

The ng generate command is not fully supported yet.
It is being considered for the main ng options, however since it does not have avaliableOptions but rather an aliasMap, it requires more work.

…little tweaking in the case-block.

…ntirely. The options and aliases are generated dynamically. There are options to only produce bash- or zsh-specific code.

catull · 2017-01-15T23:03:34Z

PR is large, it introduces command options.
Would like to get some feed-back.

…is no reason we should capture std error and stuff it into .bashrc / .zshrc. Let's just capture std output instead.

Convert function displayCaseBlock() into const caseBlock. Convert let-variables into constants.

… front of each line it writes. Reverting to console.log.

hansl · 2017-01-19T00:34:09Z

README.md

@@ -289,19 +289,19 @@ To turn on auto completion use the following commands:

 For bash:
 ```bash
-ng completion 1>> ~/.bashrc 2>>&1
+ng completion --bash 1>> ~/.bashrc


Drop the 1 in 1>>.

Okay, changed it in completion.ts, too.

hansl

A few nits, should take you all of 5 minutes. Please note that README is being moved to wiki.

cc @Brocco

hansl · 2017-01-31T21:46:49Z

packages/angular-cli/commands/completion.ts

+                caseBlock +
+                '    *) opts="" ;;';
+
+    console.log(`###-begin-ng-completion###


Could you use stripIndent from common-tags and indent the whole string? Look at other places where we use it for an example.

hansl · 2017-01-31T21:47:31Z

packages/angular-cli/commands/completion.ts

+
+    if (commandOptions.all || commandOptions.bash) {
+      console.log(`_ng_completion() {
+  local cword pword opts


Same here; use stripIndent so we keep the indentation in the code (I don't care much about the generated files).

hansl · 2017-01-31T22:27:21Z

LGTM. Awesome!

hansl · 2017-01-31T22:27:37Z

Waiting for the e2e tests to complete then I'll merge this in time for the beta

Brocco · 2017-02-01T02:14:13Z

I have a request (which can be a separate PR) to extract the availableOptions into a separate file so it can be used by other things than just completion. And with that add the ability to parse out the availableOptions from blueprints as well.

catull · 2017-02-01T19:52:06Z

@Brocco @hansl
Does this mean this PR is put on hold until the factoring out has happened and the PR is updated accordingly ?

hansl · 2017-02-01T20:05:19Z

No I'm fine with this PR as it is today. Mike does that impede your work?

catull · 2017-02-01T20:09:44Z

I can open a new issue to introduce a separation of availableOptions / blueprints into, say _.options.ts.

catull · 2017-02-03T04:32:37Z

@Brocco New PR #4267 has the separated options / blueprints.

It requires little tweaking in the case-block. Now the completion shell script is generated out of TypeScript code entirely. The options and aliases are generated dynamically. There are options to only produce bash- or zsh-specific code. Closes angular#3981.

angular-automatic-lock-bot · 2019-09-11T19:42:46Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

Completion.sh is generated in a much more automated way. It requires …

99b5636

…little tweaking in the case-block.

googlebot added the cla: yes label Jan 13, 2017

Merge branch 'master' into enhancement-automation-of-completion-script

746e964

filipesilva added the state: WIP label Jan 13, 2017

catull added 2 commits January 15, 2017 20:05

Merge from master

f9800b7

Now the completion shell script is generated out of TypeScript code e…

8045f0e

…ntirely. The options and aliases are generated dynamically. There are options to only produce bash- or zsh-specific code.

catull mentioned this pull request Jan 15, 2017

Chore completion update #3807

Closed

catull and others added 2 commits January 18, 2017 21:28

Work around 100-character line length limit.

cab0460

Merge branch 'master' into enhancement-automation-of-completion-script

e397ff8

catull mentioned this pull request Jan 18, 2017

ng completion command fails #3048

Closed

catull and others added 2 commits January 18, 2017 22:55

Solution for the redirection. Actually, with the new solution, there …

293e97b

…is no reason we should capture std error and stuff it into .bashrc / .zshrc. Let's just capture std output instead.

Merge branch 'master' into enhancement-automation-of-completion-script

a459242

filipesilva requested a review from hansl January 18, 2017 22:53

filipesilva added pr_action: review and removed state: WIP labels Jan 18, 2017

filipesilva assigned hansl Jan 18, 2017

catull and others added 11 commits January 21, 2017 12:32

merge from master

a4c299c

Replace console.log() with this.ui.writeLine().

b249f5a

Convert function displayCaseBlock() into const caseBlock. Convert let-variables into constants.

Rewrote comkpletion.ts, deeply inspired by help.ts.

0f3c82e

Merge branch 'master' into enhancement-automation-of-completion-script

3de15a5

Merge branch 'master' into enhancement-automation-of-completion-script

a56a1ea

rawArgs are not used. this.ui.writeLine always prepends ANSI codes in…

5c999a2

… front of each line it writes. Reverting to console.log.

Do not consider easter-egg, destroy or github-pages-deploy.

4e10a23

Merge branch 'master' into enhancement-automation-of-completion-script

c390dab

Merge branch 'master' into enhancement-automation-of-completion-script

69d1b55

Merge branch 'master' into enhancement-automation-of-completion-script

6a840d6

Merge branch 'master' into enhancement-automation-of-completion-script

443fbed

hansl removed the pr_action: review label Jan 27, 2017

Merge branch 'master' into enhancement-automation-of-completion-script

9f7335b

Merge from master to test new options of

da3d31a

catull changed the title ~~Completion.sh is generated in a much more automated way.~~ chore(completion) - generate shell script in a much more automated way Jan 28, 2017

Merge branch 'master' into enhancement-automation-of-completion-script

1739176

hansl suggested changes Jan 31, 2017

View reviewed changes

catull and others added 2 commits January 31, 2017 23:23

Resolving review findings.

ed1e303

Merge branch 'master' into enhancement-automation-of-completion-script

58a5646

hansl approved these changes Jan 31, 2017

View reviewed changes

Merge branch 'master' into enhancement-automation-of-completion-script

e322284

hansl closed this in d2f8ca7 Feb 3, 2017

catull deleted the enhancement-automation-of-completion-script branch February 3, 2017 04:31

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(completion) - generate shell script in a much more automated way #3981

chore(completion) - generate shell script in a much more automated way #3981

catull commented Jan 13, 2017 •

edited

Loading

catull commented Jan 15, 2017

hansl Jan 19, 2017

catull Jan 31, 2017

hansl left a comment

hansl Jan 31, 2017

catull Jan 31, 2017

hansl Jan 31, 2017

catull Jan 31, 2017

hansl commented Jan 31, 2017

hansl commented Jan 31, 2017

Brocco commented Feb 1, 2017

catull commented Feb 1, 2017

hansl commented Feb 1, 2017

catull commented Feb 1, 2017

catull commented Feb 3, 2017

angular-automatic-lock-bot bot commented Sep 11, 2019

chore(completion) - generate shell script in a much more automated way #3981

chore(completion) - generate shell script in a much more automated way #3981

Conversation

catull commented Jan 13, 2017 • edited Loading

catull commented Jan 15, 2017

hansl Jan 19, 2017

Choose a reason for hiding this comment

catull Jan 31, 2017

Choose a reason for hiding this comment

hansl left a comment

Choose a reason for hiding this comment

hansl Jan 31, 2017

Choose a reason for hiding this comment

catull Jan 31, 2017

Choose a reason for hiding this comment

hansl Jan 31, 2017

Choose a reason for hiding this comment

catull Jan 31, 2017

Choose a reason for hiding this comment

hansl commented Jan 31, 2017

hansl commented Jan 31, 2017

Brocco commented Feb 1, 2017

catull commented Feb 1, 2017

hansl commented Feb 1, 2017

catull commented Feb 1, 2017

catull commented Feb 3, 2017

angular-automatic-lock-bot bot commented Sep 11, 2019

catull commented Jan 13, 2017 •

edited

Loading