Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove addon code from ember. #3695

Merged
merged 1 commit into from
Dec 28, 2016
Merged

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Dec 22, 2016

No description provided.

@CarreraPHP
Copy link
Contributor

@hansl, with the removal of addon code from ember what is the roadmap for addon support in angular-cli? When implemented, will it be a separate ecosystem, there will be default support to ember-cli addons or there will be a migration tool or guide from ember-cli to angular-cli.

@hansl
Copy link
Contributor Author

hansl commented Dec 28, 2016

Separate ecosystem. We have a great design that's coming up after 1.0.

@hansl hansl merged commit 8b1c039 into angular:master Dec 28, 2016
@hansl hansl deleted the remove-addons branch December 28, 2016 20:58
@JohannesHoppe
Copy link
Contributor

This makes me really sad, because I actually made several angular-cli addons.
For God's sake, why didn't you decided to keep the old code until you have that alternative addon-system??

JohannesHoppe added a commit to angular-schule/angular-cli-ghpages that referenced this pull request Dec 30, 2016
@filipesilva
Copy link
Contributor

filipesilva commented Jan 14, 2017

@JohannesHoppe I'm sorry this broke the addons you had, although to be fair last time the issue was brought up I believe I mentioned that there was no warranty Ember-CLI addon system would be there in the future for Angular-CLI.

We had to remove it because it was slowing down ng command initialization and in some cases also had some bugs. Some users reported delays of several seconds on ng version for instance.

Personally I think your work in https://github.com/angular-buch/angular-cli-ghpages is great and wanted to replace the current command in the CLI with it (or a similar version based on https://github.com/tschaub/gh-pages). I haven't done it yet because it's low prio compared to other things.

@piotrtomiak
Copy link

piotrtomiak commented Jan 25, 2017

@filipesilva @hansl this breaks integration of Angular CLI with our Angular IDE as well. I know this is all in beta stages, but it's painful to see such drastic changes without any alternatives provided, when you invest a lot of time to have nice integration. How can we help/contribute to get some basic add-on mechanism pretty quickly into Angular CLI ?

MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants