build: update to TypeScript 5.9 beta #30740
Conversation
angular-robot
bot
added
the
area: build & ci
crisbeto
force-pushed
the
ts-5.9-beta
branch
8 times, most recently
from
cf0806c to
a3cf5b4
Compare
| @@ -149,12 +149,12 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => { | |||
| [ | |||
| async () => { | |||
| // Add invalid block syntax | |||
| await harness.appendToFile('src/app/app.component.html', '@one'); | |||
| await harness.appendToFile('src/app/app.component.html', '@if-one'); | |||
There was a problem hiding this comment.
I had to change this test, because in the latest version Angular is a bit more permissive about parsing unsupported blocks.
crisbeto
added
the
action: review
| @@ -38,11 +38,15 @@ export function subscribeToWorkflow( | |||
| ); | |||
| break; | |||
| case 'update': | |||
| logs.push(`${colors.cyan('UPDATE')} ${eventPath} (${event.content.length} bytes)`); | |||
| logs.push( | |||
| `${colors.cyan('UPDATE')} ${eventPath} (${(event.content as unknown as Buffer).length} bytes)`, | |||
There was a problem hiding this comment.
This does not seem ideal from a type safety perspective.
Is there some information/context on the changes needed here?
There was a problem hiding this comment.
So as far as I could tell, the types didn't really change but TS is being better at enforcing them. I did start to update the types, but it ended up spanning a ton of files so decided to keep the change simple for now.
There was a problem hiding this comment.
Ok. makes sense.
Can you add some TODOs in there so we can clean this up later on?
There was a problem hiding this comment.
Done, I've added TODOs on all those as unknown as cases.
Updates the repo to the TypeScript 5.9 beta and widens the peer dependency ranges.
crisbeto
added
action: merge
Updates the repo to the TypeScript 5.9 beta and widens the peer dependency ranges.