-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): use baseUrl and paths from tsconfig #2470
Conversation
8b8c5ff
to
9fae6d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
That's awesome ;) Thanks! |
Awesome!!!! |
@filipesilva What issue can I follow that tracks support for --aot with I use |
@filipesilva Would you have any pointers as to what could be done as a workaround for aot support? Thanks! |
@arlowhite @altschuler I'm not sure what the problem you are describing is, AFAIK TS paths work for aot. Can you open a new issue with a repro of what you're experiencing? |
@filipesilva I'm not sure custom paths are the root cause. You can ignore my comment. Just FYI... My AOT build with I started to work on fixing the animations: [
trigger('fade', [
state('hide' as FadeState, style({ The After fixing that, I got hundreds of errors reporting that Component fields were private that needed to be public for AOT. I haven't had time to work through those issues yet, so don't know if the build will actually work now. |
@filipesilva Please ignore, problem turned out to be something completely different, baseUrl and paths work great with aot :) |
@arlowhite there was a bug pre-1.0 that was hiding a lot of AOT errors (like the private members), and was discussed #5623. This did result in a lot more AOT errors being reported in 1.0. They were mostly 'real' AOT errors though, and a few that weren't were fixed. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Supersedes #2210 #2392 #2428.
Uses same base mechanism as @abner's #2210, but edits the new
webpack-build-typescript.ts
and adds tests.Does NOT currently work for
--aot
(/cc @hansl).