fix(@angular-devkit/build-angular): limit advanced terser passes to two #21324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limiting the terser passes to two helps to workaround an issue with terser wherein terser will errantly inline a function argument containing a `yield` expression inside an inner arrow function. This results in a syntax error since the yield expression is no longer within the scope of a generator.
alan-agius4
reviewed
Jul 10, 2021
packages/angular_devkit/build_angular/src/webpack/plugins/javascript-optimizer-worker.ts
Show resolved
Hide resolved
alan-agius4
approved these changes
Jul 12, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limiting the terser passes to two helps to workaround an issue with terser wherein terser will errantly inline a function argument containing a
yieldexpression inside an inner arrow function. This results in a syntax error since the yield expression is no longer within the scope of a generator.Reducing the number of terser passes to two does cause a minor increase in size as shown below. However, the change is far less than 1% in both cases.