-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add loader for gif #1888
fix: add loader for gif #1888
Conversation
+1 on getting this merged in! |
+1 for this! |
+1 for this |
Lack of |
What exactly does this enable you to do? |
@FallenRiteMonk 2 things:
|
{ test: /\.gif$/i, | ||
loaders: [ | ||
'file?hash=sha512&digest=hex&name=[hash].[ext]', | ||
'image-webpack?bypassOnDebug&optimizationLevel=7&interlaced=false' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all these query options for the image min library?
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
CLAs look good, thanks! |
# The first commit's message is: fix: add loader for gif add loader to support loading of gif images Closes #1878 # The 2nd commit message will be skipped: # fix(lint): Updated the main.ts's blueprint to fix the ng lint failure (#1903) (#1904) # # The 3rd commit message will be skipped: # Fix for issue 1876: noImplicitAny means make them explicite (#1892) #
messed this up with rebase! created a new PR #2066 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
add loader to support loading of gif images
Closes #1878