Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@angular/cli@1.1.1 ignores custom ngsw-manifest.json instead of merging it with auto-generated one #6654

Closed
webmaxru opened this issue Jun 12, 2017 · 1 comment · Fixed by #6758
Closed

@angular/cli@1.1.1 ignores custom ngsw-manifest.json instead of merging it with auto-generated one #6654

webmaxru opened this issue Jun 12, 2017 · 1 comment · Fixed by #6758
Assignees
@alxhub
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity2: inconvenient

Comments

@webmaxru
Copy link
Member

Bug Report or Feature Request (mark with an x)

- [x] bug report
- [ ] feature request

Versions.

@angular/cli: 1.1.1
@angular/cli: 1.2.0-beta.1

Repro steps.

  • Set "serviceWorker": true for your app in .angular-cli.json
  • Create a simple custom ngsw-manifest.json in project root, for example:
    { "push": { "showNotifications": true } }
  • Run ng build --prod
  • Generated dist/ngsw-manifest.json will contain only static plugin settings, push will be ignored.
  • Roll back to CLI 1.0.4 to see the difference

Repo to experiment with

https://github.com/webmaxru/pwa-workshop-angular/tree/step9
@Brocco Brocco added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity2: inconvenient labels Jun 14, 2017
@webmaxru webmaxru mentioned this issue Jun 15, 2017
Closed
alxhub added a commit to alxhub/angular-cli that referenced this issue Jun 20, 2017
@alxhub
fix: check for existing SW manifest should look in project dir
85148da 
A previous change broke the logic which brings an application ngsw-manifest.json into the Webpack build for merging with the auto-generated configuration. It caused the GlobCopyWebpackPlugin to look in the wrong directory for the existing manifest. This change sets the working directory for the copy plugin explicitly.

Fixes angular#6654.
@alxhub alxhub mentioned this issue Jun 20, 2017
Merged
alxhub added a commit to alxhub/angular-cli that referenced this issue Jun 20, 2017
@alxhub
fix: check for existing SW manifest should look in project dir
0a6bb32 
A previous change broke the logic which brings an application ngsw-manifest.json into the Webpack build for merging with the auto-generated configuration. It caused the GlobCopyWebpackPlugin to look in the wrong directory for the existing manifest. This change sets the working directory for the copy plugin explicitly.

Fixes angular#6654.
alxhub added a commit to alxhub/angular-cli that referenced this issue Jun 20, 2017
@alxhub
fix(@angular/cli): check for existing SW manifest should look in proj…
4a8b962 
…ect dir

A previous change broke the logic which brings an application ngsw-manifest.json into the Webpack build for merging with the auto-generated configuration. It caused the GlobCopyWebpackPlugin to look in the wrong directory for the existing manifest. This change sets the working directory for the copy plugin explicitly.

Fixes angular#6654.
hansl pushed a commit that referenced this issue Jun 21, 2017
@alxhub @hansl
fix(@angular/cli): check for existing SW manifest should look in proj…
220e59d 
…ect dir

A previous change broke the logic which brings an application ngsw-manifest.json into the Webpack build for merging with the auto-generated configuration. It caused the GlobCopyWebpackPlugin to look in the wrong directory for the existing manifest. This change sets the working directory for the copy plugin explicitly.

Fixes #6654.
Brocco pushed a commit that referenced this issue Jun 21, 2017
@alxhub @Brocco
fix(@angular/cli): check for existing SW manifest should look in proj…
b8c50c1 
…ect dir

A previous change broke the logic which brings an application ngsw-manifest.json into the Webpack build for merging with the auto-generated configuration. It caused the GlobCopyWebpackPlugin to look in the wrong directory for the existing manifest. This change sets the working directory for the copy plugin explicitly.

Fixes #6654.
Brocco pushed a commit that referenced this issue Jun 21, 2017
@alxhub @Brocco
fix(@angular/cli): check for existing SW manifest should look in proj…
fd5ff1f 
…ect dir

A previous change broke the logic which brings an application ngsw-manifest.json into the Webpack build for merging with the auto-generated configuration. It caused the GlobCopyWebpackPlugin to look in the wrong directory for the existing manifest. This change sets the working directory for the copy plugin explicitly.

Fixes #6654.
mac2000 pushed a commit to mac2000/angular-cli that referenced this issue Jun 22, 2017
@alxhub @mac2000
fix(@angular/cli): check for existing SW manifest should look in proj…
415824c 
…ect dir

A previous change broke the logic which brings an application ngsw-manifest.json into the Webpack build for merging with the auto-generated configuration. It caused the GlobCopyWebpackPlugin to look in the wrong directory for the existing manifest. This change sets the working directory for the copy plugin explicitly.

Fixes angular#6654.
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
@alxhub @dond2clouds
fix(@angular/cli): check for existing SW manifest should look in proj…
a7c115b 
…ect dir

A previous change broke the logic which brings an application ngsw-manifest.json into the Webpack build for merging with the auto-generated configuration. It caused the GlobCopyWebpackPlugin to look in the wrong directory for the existing manifest. This change sets the working directory for the copy plugin explicitly.

Fixes angular#6654.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alxhub alxhub

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity2: inconvenient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check for existing SW manifest should look in project dir alxhub/angular-cli
3 participants
@webmaxru @Brocco @alxhub