Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use protractor api instead of npm run e2e in ng e2e #4256

Closed
filipesilva opened this issue Jan 27, 2017 · 2 comments · Fixed by #4527
Closed

Use protractor api instead of npm run e2e in ng e2e #4256

filipesilva opened this issue Jan 27, 2017 · 2 comments · Fixed by #4527
Assignees
@filipesilva
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful

Comments

@filipesilva
Copy link
Contributor

filipesilva commented Jan 27, 2017 •
edited
Loading

When running ng e2e we just call npm run e2e. We should use the protractor API instead since it gives us better control over output and config.

A similar move was done for lint in #4248.
@filipesilva filipesilva added command: test P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Jan 27, 2017
@filipesilva filipesilva self-assigned this Feb 3, 2017
@filipesilva filipesilva mentioned this issue Feb 3, 2017
Closed
@hansl
Copy link
Contributor

hansl commented Feb 3, 2017

Reminder to implement an npm script "e2e": "ng e2e".

@filipesilva filipesilva mentioned this issue Feb 7, 2017
Closed
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Feb 8, 2017
@filipesilva
feat(e2e): use protractor api
fa9f986 
Uses existing Protractor API to run it directly instead of using `npm run
e2e`.

Also adds support for the following flags: `--serve`, `--config`,
`--specs`, `--element-explorer`, `--webdriver-update`.

Fix angular#4256
Fix angular#4478

BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
@filipesilva filipesilva mentioned this issue Feb 8, 2017
Merged
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Feb 8, 2017
@filipesilva
feat(e2e): use protractor api
6bb0a71 
Uses existing Protractor API to run it directly instead of using `npm run
e2e`.

Also adds support for the following flags: `--serve`, `--config`,
`--specs`, `--element-explorer`, `--webdriver-update`.

Fix angular#4256
Fix angular#4478

BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Feb 8, 2017
@filipesilva
feat(e2e): use protractor api
e8b2066 
Uses existing Protractor API to run it directly instead of using `npm run
e2e`.

Also adds support for the following flags: `--serve`, `--config`,
`--specs`, `--element-explorer`, `--webdriver-update`.

Fix angular#4256
Fix angular#4478

BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Feb 8, 2017
@filipesilva
feat(e2e): use protractor api
ab02a2e 
Uses existing Protractor API to run it directly instead of using `npm run
e2e`.

Also adds support for the following flags: `--serve`, `--config`,
`--specs`, `--element-explorer`, `--webdriver-update`.

Fix angular#4256
Fix angular#4478

BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Feb 9, 2017
@filipesilva
feat(e2e): use protractor api
84fca65 
Uses existing Protractor API to run it directly instead of using `npm run
e2e`.

Also adds support for the following flags: `--serve`, `--config`,
`--specs`, `--element-explorer`, `--webdriver-update`.

Fix angular#4256
Fix angular#4478

BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Feb 9, 2017
@filipesilva
feat(e2e): use protractor api
98d1714 
Uses existing Protractor API to run it directly instead of using `npm run
e2e`.

Also adds support for the following flags: `--serve`, `--config`,
`--specs`, `--element-explorer`, `--webdriver-update`.

Fix angular#4256
Fix angular#4478

BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
hansl pushed a commit that referenced this issue Feb 9, 2017
@filipesilva @hansl
feat(e2e): use protractor api (#4527)
8d2d93a 
Uses existing Protractor API to run it directly instead of using `npm run
e2e`.

Also adds support for the following flags: `--serve`, `--config`,
`--specs`, `--element-explorer`, `--webdriver-update`.

Fix #4256
Fix #4478

BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this issue Apr 12, 2017
@filipesilva
feat(e2e): use protractor api (angular#4527)
05e9e5c 
Uses existing Protractor API to run it directly instead of using `npm run
e2e`.

Also adds support for the following flags: `--serve`, `--config`,
`--specs`, `--element-explorer`, `--webdriver-update`.

Fix angular#4256
Fix angular#4478

BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@filipesilva filipesilva

Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(e2e): use protractor api filipesilva/angular-cli
2 participants
@hansl @filipesilva