-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(polyfills): move polyfills to own entry point #3812
Conversation
e1506f0
to
e289a55
Compare
Webpack also accepts modules/package names as entry option.
Would not this be a cleaner solution? |
@cebor it's true that webpack accepts that, but the purpose of the |
69426a6
to
c2a2ea9
Compare
@hansl see #2233 (comment), adding the long stack trace is not the solution to that issue. |
Also need to add a lot of comments to polyfills to show opt-in ones for each browser. |
Polyfills found in polyfills.ts would not be available for scripts due to being loaded in the main bundle only. Fix angular#2752 Fix angular#3309
c2a2ea9
to
611b655
Compare
LGTM, Thanks! |
Polyfills found in polyfills.ts would not be available for scripts due to being loaded in the main bundle only. This PR loads polyfills as a separate entry point, before everything else. Extra documentation also added to polyfills.ts. Fix angular#2752 Fix angular#3309 Fix angular#4140
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Polyfills found in
polyfills.ts
would not be available for scripts due to being loaded in the main bundle only.This PR loads polyfills as a separate entry point, before everything else.
Extra documentation also added to
polyfills.ts
.Fix #2752
Fix #3309
Fix #4140