Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematic input does not validate against the Schema #28189

Closed
adamwoxsoft opened this issue Aug 11, 2024 · 2 comments · Fixed by #28191
Closed

Schematic input does not validate against the Schema #28189

adamwoxsoft opened this issue Aug 11, 2024 · 2 comments · Fixed by #28191

Comments

@adamwoxsoft
Copy link

Which @angular/* package(s) are the source of the bug?

Don't known / other

Is this a regression?

Yes

Description

I'm trying to create a guard with ng g guard shared/utils/auth. Path exists.

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

Schematic input does not validate against the Schema: {"skipTests":true,"name":"shared/utils/auth","project":"woxoptima.client","implements":[]}
Errors:

  Data path "/implements" must NOT have fewer than 1 items.

Please provide the environment you discovered this bug in (run ng version)

_                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/


Angular CLI: 18.1.4
Node: 20.11.1
Package Manager: npm 10.2.4
OS: win32 x64

Angular: 18.1.4
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, material, platform-browser, platform-browser-dynamic
... router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1801.4
@angular-devkit/build-angular   18.1.4
@angular-devkit/core            18.1.4
@angular-devkit/schematics      18.1.4
@schematics/angular             18.1.4
rxjs                            7.8.1
typescript                      5.5.4
zone.js                         0.14.10

Anything else?

No response

@JoostK JoostK transferred this issue from angular/angular Aug 11, 2024
@alan-agius4
Copy link
Collaborator

This happened because an "implementation" step was likely skipped when using the prompts. We should not allow processing to continue when a choice prompt requires a minimum of one input.

alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 12, 2024
…ation failure

Previously, when a select or checkbox prompt failed validation, it was bypassed, preventing users from correcting their input. This commit ensures that when validation fails, the prompts are re-displayed, allowing users to make the necessary corrections. This improves the user experience and helps avoid unintended selections.

Closes angular#28189
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 12, 2024
…x prompts on validation failure

Previously, when a select or checkbox prompt failed validation, it was bypassed, preventing users from correcting their input. This commit ensures that when validation fails, the prompts are re-displayed, allowing users to make the necessary corrections. This improves the user experience and helps avoid unintended selections.

Closes angular#28189
alan-agius4 added a commit that referenced this issue Aug 12, 2024
…x prompts on validation failure

Previously, when a select or checkbox prompt failed validation, it was bypassed, preventing users from correcting their input. This commit ensures that when validation fails, the prompts are re-displayed, allowing users to make the necessary corrections. This improves the user experience and helps avoid unintended selections.

Closes #28189
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 14, 2024
…ation failure

Previously, when a select or checkbox prompt failed validation, it was bypassed, preventing users from correcting their input. This commit ensures that when validation fails, the prompts are re-displayed, allowing users to make the necessary corrections. This improves the user experience and helps avoid unintended selections.

Closes angular#28189

(cherry picked from commit fae9542)
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 14, 2024
…x prompts on validation failure

Previously, when a select or checkbox prompt failed validation, it was bypassed, preventing users from correcting their input. This commit ensures that when validation fails, the prompts are re-displayed, allowing users to make the necessary corrections. This improves the user experience and helps avoid unintended selections.

Closes angular#28189

(cherry picked from commit d4e95f2)
alan-agius4 added a commit that referenced this issue Aug 14, 2024
…ation failure

Previously, when a select or checkbox prompt failed validation, it was bypassed, preventing users from correcting their input. This commit ensures that when validation fails, the prompts are re-displayed, allowing users to make the necessary corrections. This improves the user experience and helps avoid unintended selections.

Closes #28189

(cherry picked from commit fae9542)
alan-agius4 added a commit that referenced this issue Aug 14, 2024
…x prompts on validation failure

Previously, when a select or checkbox prompt failed validation, it was bypassed, preventing users from correcting their input. This commit ensures that when validation fails, the prompts are re-displayed, allowing users to make the necessary corrections. This improves the user experience and helps avoid unintended selections.

Closes #28189

(cherry picked from commit d4e95f2)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants