Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell users what migrations were actually performed instead of what was considered #24488

Closed
StephenFluin opened this issue Jan 5, 2023 · 3 comments · Fixed by #24565
Closed
Labels
area: @angular/cli feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature ng update DX

Comments

@StephenFluin
Copy link
Contributor

Command

update

Description

Currently ng update does a good job of telling you which migrations the CLI is attempting to apply, but you don't know which migrations actually were applied.

Describe the solution you'd like

I'd love it if the migrations reports / logs actually logged what changes were made. Example console output before:

UPDATE angular.json (3617 bytes)
  Migration completed.

▸ Remove 'showCircularDependencies' option from browser and server builders.
  Migration completed.

▸ Replace 'defaultCollection' option in workspace configuration with 'schematicCollections'.
  Migration completed.

▸ Update Angular packages 'dependencies' and 'devDependencies' version prefix to '^' instead of '~'.

Example after:

UPDATE angular.json (3617 bytes)
  Migration completed - no changes made.

▸ Remove 'showCircularDependencies' option from browser and server builders.
  Migration completed - no changes made.

▸ Replace 'defaultCollection' option in workspace configuration with 'schematicCollections'.
  Migration completed - 3 updates made.

▸ Update Angular packages 'dependencies' and 'devDependencies' version prefix to '^' instead of '~'.
Migration completed - 15 updates made.

Describe alternatives you've considered

No response

@alan-agius4 alan-agius4 added feature Issue that requests a new feature area: @angular/cli ng update DX labels Jan 6, 2023
@angular-robot angular-robot bot added the feature: votes required Feature request which is currently still in the voting phase label Jan 6, 2023
@angular-robot
Copy link
Contributor

angular-robot bot commented Jan 6, 2023

This feature request is now candidate for our backlog! In the next phase, the community has 60 days to upvote. If the request receives more than 20 upvotes, we'll move it to our consideration list.

You can find more details about the feature request process in our documentation.

alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Jan 18, 2023
This commit updates `ng update` to include the number of files updated when a migration is completed.

Closes angular#24488
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Jan 19, 2023
This commit updates `ng update` to include the number of files updated when a migration is completed.

Closes angular#24488
angular-robot bot pushed a commit that referenced this issue Jan 19, 2023
This commit updates `ng update` to include the number of files updated when a migration is completed.

Closes #24488
@StephenFluin
Copy link
Contributor Author

❤️

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @angular/cli feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature ng update DX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants