Skip to content

Commit

Permalink
chore(build): use cheap-module-source-map for dev (#2619)
Browse files Browse the repository at this point in the history 
Allows for faster builds, partially addresses #1980
  • Loading branch information
@filipesilva
filipesilva authored Oct 10, 2016
1 parent a66c8cc commit dbdf46c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/angular-cli/models/webpack-build-development.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ declare module 'webpack' {

export const getWebpackDevConfigPartial = function(projectRoot: string, appConfig: any) {
return {
devtool: 'source-map',
devtool: 'cheap-module-source-map',
output: {
path: path.resolve(projectRoot, appConfig.outDir),
filename: '[name].bundle.js',
Expand Down

5 comments on commit dbdf46c

@jmesa-sistel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @filipesilva
I have tested this commit in my test project and now the breakpoints are not accurate, when I set a breakpoint is moved to another line, please verify it.

@dzonatan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's cheap :trollface:

@filipesilva
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda chose this one because it seems to always provide the right line. @jmesa-sistel can you open an issue with a repro I can follow to see what you see?

@jmesa-sistel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok
SimpleAngular2Test
Using Windows 10 pc.
Added primeng to the project (src/app/app.module.ts & src/styles.css)
Run: ng serve
In VSCode
Add a breakpoint in app.component.ts in Test functionin second line.
Debug with F5, a new chrome will be opened, press Test button.

@filipesilva
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmesa-sistel that seems to be this VSCode related issue instead #2453 (comment)

Please sign in to comment.