fix(@angular-devkit/build-angular): remove left-over `forkTypeChecker…

…` option (cherry picked from commit 4c8e032)
angular · Apr 22, 2021 · 57ac7f3 · 57ac7f3
1 parent 7c288c8
commit 57ac7f3
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 14 deletions.
diff --git a/packages/angular_devkit/build_angular/src/browser/schema.json b/packages/angular_devkit/build_angular/src/browser/schema.json
@@ -344,11 +344,6 @@
       "description": "Generates a 'stats.json' file which can be analyzed using tools such as 'webpack-bundle-analyzer'.",
       "default": false
     },
-    "forkTypeChecker": {
-      "type": "boolean",
-      "description": "Run the TypeScript type checker in a forked process.",
-      "default": true
-    },
     "budgets": {
       "description": "Budget thresholds to ensure parts of your application stay within boundaries which you set.",
       "type": "array",

diff --git a/packages/angular_devkit/build_angular/src/browser/specs/rebuild_spec.ts b/packages/angular_devkit/build_angular/src/browser/specs/rebuild_spec.ts
@@ -151,7 +151,7 @@ describe('Browser Builder rebuilds', () => {
     `,
     );
 
-    const overrides = { watch: true, forkTypeChecker: false };
+    const overrides = { watch: true };
     const logger = new logging.Logger('');
     let logs: string[] = [];
     logger.subscribe(e => logs.push(e.message));
@@ -344,7 +344,7 @@ describe('Browser Builder rebuilds', () => {
     // `selector must be a string` errors on VE are part of the emit result, but on Ivy they only
     // show up in getNgSemanticDiagnostics. Since getNgSemanticDiagnostics is only called on the
     // type checker, we must disable it to get a failing fourth build with Ivy.
-    const overrides = { watch: true, aot: true, forkTypeChecker: false };
+    const overrides = { watch: true, aot: true };
     const logger = new logging.Logger('');
     let logs: string[] = [];
     logger.subscribe(e => logs.push(e.message));

diff --git a/packages/angular_devkit/build_angular/src/server/schema.json b/packages/angular_devkit/build_angular/src/server/schema.json
@@ -220,11 +220,6 @@
       "description": "Generates a 'stats.json' file which can be analyzed using tools such as 'webpack-bundle-analyzer'.",
       "default": false
     },
-    "forkTypeChecker": {
-      "type": "boolean",
-      "description": "Run the TypeScript type checker in a forked process.",
-      "default": true
-    },
     "watch": {
       "type": "boolean",
       "description": "Run build when files change.",

diff --git a/packages/angular_devkit/build_angular/src/utils/build-options.ts b/packages/angular_devkit/build_angular/src/utils/build-options.ts
@@ -57,7 +57,6 @@ export interface BuildOptions {
   serviceWorker?: boolean;
   webWorkerTsConfig?: string;
   statsJson: boolean;
-  forkTypeChecker: boolean;
   hmr?: boolean;
   main: string;
   polyfills?: string;

diff --git a/packages/angular_devkit/build_angular/src/utils/normalize-builder-schema.ts b/packages/angular_devkit/build_angular/src/utils/normalize-builder-schema.ts
@@ -50,7 +50,6 @@ export function normalizeBrowserSchema(
     sourceMap: normalizedSourceMapOptions,
     preserveSymlinks: options.preserveSymlinks === undefined ? process.execArgv.includes('--preserve-symlinks') : options.preserveSymlinks,
     statsJson: options.statsJson || false,
-    forkTypeChecker: options.forkTypeChecker || false,
     budgets: options.budgets || [],
     scripts: options.scripts || [],
     styles: options.styles || [],

diff --git a/packages/schematics/angular/migrations/update-12/update-angular-config.ts b/packages/schematics/angular/migrations/update-12/update-angular-config.ts
@@ -47,6 +47,7 @@ export default function (): Rule {
       for (const [, options] of allTargetOptions(target)) {
         delete options.experimentalRollupPass;
         delete options.lazyModules;
+        delete options.forkTypeChecker;
       }
     }
   });