Skip to content

Commit

Permalink
refactor(@angular-devkit/build-angular): remove view engine app-shell…
Browse files Browse the repository at this point in the history
… generation

BREAKING CHANGE:  App-shell builder now only supports generation using Ivy
  • Loading branch information
alan-agius4 authored and filipesilva committed Mar 30, 2021
1 parent 14c8a09 commit 1c2aeeb
Showing 1 changed file with 3 additions and 12 deletions.
15 changes: 3 additions & 12 deletions packages/angular_devkit/build_angular/src/app-shell/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,21 +72,12 @@ async function _renderUniversal(

const {
AppServerModule,
AppServerModuleNgFactory,
renderModule,
renderModuleFactory,
} = await import(serverBundlePath);

let renderModuleFn: (module: unknown, options: {}) => Promise<string>;
let AppServerModuleDef: unknown;
const renderModuleFn: ((module: unknown, options: {}) => Promise<string>) | undefined = renderModule;

if (renderModuleFactory && AppServerModuleNgFactory) {
renderModuleFn = renderModuleFactory;
AppServerModuleDef = AppServerModuleNgFactory;
} else if (renderModule && AppServerModule) {
renderModuleFn = renderModule;
AppServerModuleDef = AppServerModule;
} else {
if (!(renderModuleFn && AppServerModule)) {
throw new Error(`renderModule method and/or AppServerModule were not exported from: ${serverBundlePath}.`);
}

Expand All @@ -96,7 +87,7 @@ async function _renderUniversal(
url: options.route,
};

let html = await renderModuleFn(AppServerModuleDef, renderOpts);
let html = await renderModuleFn(AppServerModule, renderOpts);
// Overwrite the client index file.
const outputIndexPath = options.outputIndexPath
? path.join(root, options.outputIndexPath)
Expand Down

0 comments on commit 1c2aeeb

Please sign in to comment.