Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

feat: switch to Ivy #505

Closed
wants to merge 3 commits into from
Closed

feat: switch to Ivy #505

wants to merge 3 commits into from

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented Aug 15, 2019

Replaces #406 & #482

Issues remaining:

  1. yarn_install/npm_install doesn't automatically detect umd bundles when using ivy (since its test of APF depends on finding .metadata.json files) so these are not automatically added to devmode rules such as ts_devserver & ts_web_test_suite. @kyliau is working on this (ci: Add ANGULAR_PACKAGE to snapshot builds angular#31900).

NB: 9.0.0-next.2 ivy-ngcc now correctly transforms UMD bundles in npm deps such as @ngrx which are used by ts_devserver & ts_web_test_suite rules. See angular/angular#31394.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

This was referenced Aug 15, 2019
@CaerusKaru
Copy link
Member

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@alexeagle
Copy link
Contributor

moving this repo to rules_nodejs in bazel-contrib/rules_nodejs#1124
please reopen pull requests there

@alexeagle alexeagle closed this Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants