Build angular from source #160

gregmagolan · 2018-06-25T18:17:01Z

No description provided.

gregmagolan · 2018-06-25T18:17:33Z

Build & e2e working. Still have a karma test failure with a long call stack that I haven't looked into yet.

gregmagolan · 2018-06-26T01:48:25Z

Karma test failure resolved

buildsize · 2018-06-26T02:12:19Z

File name	Previous Size	New Size	Change
bundle.min.js	424.89 KB	412.45 KB	-12.43 KB (3%)

gregmagolan · 2018-06-26T02:13:22Z

Hmmm. Looks like the added memory load of building angular is crashing the JVM again. Lowered the memory usage in bazelrc some more.

gregmagolan · 2018-06-26T18:06:00Z

For reference: without the types-patch in the Angular repo package.json these are the paths that were needed for zone.js.d.ts to be loaded in modules/types.d.ts for the angular build directly and for building angular from source:

// works for @angular repo as external build
// <reference path="../../../external/angular_deps/node_modules/zone.js/dist/zone.js.d.ts" />

// works for @angular repo build
// <reference path="../external/angular_deps/node_modules/zone.js/dist/zone.js.d.ts" />

gregmagolan · 2018-08-09T00:19:00Z

@jorgeucano Yes. This PR resolves angular/angular#24521 which was introduced in Angular 6.0.5.

alexeagle · 2018-08-09T15:25:57Z

.circleci/config.yml

@@ -60,7 +60,8 @@ jobs:
      - run: bazel info release

      # Install the dependencies from NPM
-      - run: bazel run @nodejs//:yarn install
+      # TODO(gmagolan): use `bazel run :install` once bootstrap issue resolved


file an issue to reference here

which repo?

bazel-contrib/rules_nodejs#275

alexeagle · 2018-08-09T15:26:25Z

BUILD.bazel

@@ -5,11 +5,14 @@ alias(
    actual = "@nodejs//:yarn",
 )

+alias(


maybe a comment that this is the place ts_library will look by default, allows us to omit explicit tsconfig attributes?

alexeagle · 2018-08-09T15:38:27Z

WORKSPACE


 node_repositories(package_json = ["//:package.json"])

+# 0.11.3: proper module resolution & check_rules_nodejs_version
+check_rules_nodejs_version("0.11.3")


yeah users shouldn't need to do transitive checks

alexeagle · 2018-08-09T15:38:58Z

tools/bazel.rc

@@ -12,3 +12,8 @@ build --strategy=AngularTemplateCompile=worker
 build --symlink_prefix=dist/

 test --test_output=errors
+
+################################
+# Temporary Settings for Ivy   #


I mean, change the comment, ppl will think this means we are enabling Ivy in legacy mode

alexeagle · 2018-08-09T15:39:45Z

test/e2e/protractor.on-prepare.js

@@ -0,0 +1,11 @@
+const protractorUtils = require('@angular/bazel/protractor-utils');


since this repo is the canonical example, could you add more explanatory comments about when this file executes and how it relates to the protractor rule and the code under test?

alexeagle · 2018-08-09T15:40:06Z

test/e2e/BUILD.bazel


 ts_library(
    name = "e2e",
    testonly = 1,
    srcs = glob(["*.ts"]),
 )
+
+protractor_web_test_suite(


maybe we should add comments with links to API docs now that they are published

where did those get published to?

alexeagle · 2018-08-09T15:40:54Z

src/main.ts

@@ -1,3 +1,5 @@
+import 'tslib';


maybe something in Angular should depend on it. Who actually uses a symbol that requires tslib to be present? It's related to the --noHelpers flag in the tsconfig right?

gregmagolan requested a review from alexeagle June 25, 2018 18:17

gregmagolan force-pushed the build-angular-from-source branch 2 times, most recently from 9b77826 to 78b0519 Compare June 26, 2018 01:43

gregmagolan force-pushed the build-angular-from-source branch 2 times, most recently from 9697286 to e8f0c42 Compare June 26, 2018 02:58

gregmagolan mentioned this pull request Jun 26, 2018

node_modules attribute in jasmine_node_test does not take effect bazel-contrib/rules_nodejs#237

Closed

gregmagolan mentioned this pull request Jun 26, 2018

Need named AMD/UMD ngsummary.js files for Angular packages for ts_web_test_suite bazelbuild/rules_typescript#192

Closed

gregmagolan force-pushed the build-angular-from-source branch 3 times, most recently from 7c0b7fd to ea0f3b6 Compare July 23, 2018 19:58

gregmagolan force-pushed the build-angular-from-source branch from ea0f3b6 to 2bb9723 Compare July 31, 2018 20:25

This was referenced Jul 31, 2018

Stop using xvfb just for Chrome #38

Closed

Bazel build of router broken in 6.0.5 angular/angular#24521

Closed

angular deleted a comment Aug 1, 2018

gregmagolan force-pushed the build-angular-from-source branch from 20de526 to ba42a32 Compare August 1, 2018 23:07

angular deleted a comment Aug 1, 2018

gregmagolan force-pushed the build-angular-from-source branch from ba42a32 to 1f98d61 Compare August 1, 2018 23:13

angular deleted a comment Aug 9, 2018

Remove skydoc_repositories() call from WORKSPACE

7cdb988

Update README

10c5167

angular deleted a comment Aug 9, 2018

alexeagle reviewed Aug 9, 2018

View reviewed changes

gregmagolan added 2 commits August 9, 2018 10:30

Address review comments

450cc66

Add comment about protractor onPrepare function

ea8b30b

angular deleted a comment Aug 9, 2018

Address review comments

c27ed2e

alexeagle merged commit 1c40392 into angular:master Aug 9, 2018

angular deleted a comment Aug 9, 2018

gregmagolan mentioned this pull request Aug 10, 2018

Error when adding --strategy=TypeScriptCompile=worker bazelbuild/rules_typescript#220

Closed

gregmagolan mentioned this pull request Oct 26, 2018

Update to Angular 7.0.1 http_archive & @angular/bazel package angular/components#13831

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build angular from source #160

Build angular from source #160

gregmagolan commented Jun 25, 2018

gregmagolan commented Jun 25, 2018

gregmagolan commented Jun 26, 2018

buildsize bot commented Jun 26, 2018 •

edited

Loading

gregmagolan commented Jun 26, 2018

gregmagolan commented Jun 26, 2018 •

edited

Loading

gregmagolan commented Aug 9, 2018

alexeagle Aug 9, 2018

gregmagolan Aug 9, 2018

gregmagolan Aug 9, 2018

alexeagle Aug 9, 2018

gregmagolan Aug 9, 2018

alexeagle Aug 9, 2018

alexeagle Aug 9, 2018

alexeagle Aug 9, 2018

gregmagolan Aug 9, 2018

alexeagle Aug 9, 2018

gregmagolan Aug 9, 2018

alexeagle Aug 9, 2018

		@@ -0,0 +1,11 @@
		const protractorUtils = require('@angular/bazel/protractor-utils');

Build angular from source #160

Build angular from source #160

Conversation

gregmagolan commented Jun 25, 2018

gregmagolan commented Jun 25, 2018

gregmagolan commented Jun 26, 2018

buildsize bot commented Jun 26, 2018 • edited Loading

gregmagolan commented Jun 26, 2018

gregmagolan commented Jun 26, 2018 • edited Loading

gregmagolan commented Aug 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

buildsize bot commented Jun 26, 2018 •

edited

Loading

gregmagolan commented Jun 26, 2018 •

edited

Loading