feat(spinner) Added spinner on refresh and select2

[Jefiozie]

This PR is based on #248 and #1029, needed it for my own and saw that these PR's where still open.
If approved 248 can be closed and maybe 1029 also but there are some other commits there.

[user378230]

I thought the main purpose of the icon would be for async refresh calls so it should check if refreshAttr returns a promise and waits if so, see #1029.

Note: there's no tests either 🙁.

It would be nice to support selectize too if we can, as otherwise this would just mean a new issue gets raised claiming yet another bug in ui-select.

[Jefiozie]

You are probably right. Will refacto it and add some tests.

[user378230]

For reference #919 will also be closed.

[Jefiozie]

@aaronroberson or @user378230 can you have a look at this? 😄

[Jefiozie]

@user378230 did you had have some time to review this?

[ghost]

It seems there is a error by the class quotation marks https://github.com/Jefiozie/ui-select/blob/50b6bf9331782f940eb1119a785572513a20152f/src/bootstrap/select.tpl.html#L3

[Jefiozie]

@danivarga , thank you missed that one.

[aaronroberson]

@Jefiozie Can you resolve the merge conflicts and I'll get this merged in right away?

[Jefiozie]

@aaronroberson , Everything is fine.. but for some reason I added the other commits. Any thoughts on how to fix it? Don't know what happend exactly.

[aaronroberson]

@Jefiozie The conflicts appear to be resolved now and I've gone ahead and merged.

[Jefiozie]

@aaronroberson can you close #1029, #919, #248?

[bogdanalexe90]

Shouldn't you take into account the rejection case?
I think the best fit it will be something like

refreshPromise.finally(function() {

[Jefiozie]

@bogdanalexe90 made a new PR with the adjustments.

[shyamal890]

I think instead of adding spinner it would be great if only a div is made visible when refreshAttr = true. Developers can then add whatever they want inside that div. Will make the library much more extensible.

[Jefiozie]

@bogdanalexe90 , you are probably right will have a look at it Thanks for the feedback!.

@shyamal890 , interesting and people can then change the div in html with the style they like?

[shyamal890]

@Jefiozie Exactly! people can then change content inside the div and its style in whatever way they want.

Something like:

<ui-select-choices refresh="paCtrl.SearchList($select.search)" 
                              refresh-delay="800" 
                              refreshing="paCtrl.searching"
                              repeat="t as t in paCtrl.filterSearchList($select.search) track by t.Id">
              <div ng-bind-html="t.Name | highlight: $select.search"></div>
              <small>
                     <span ng-bind-html="t.Something | highlight: $select.search"></span>
              </small>
              <div ui-select-refresh>
                        //Where user can put in whatever they want
              </div>
</ui-select-choices>

[Jefiozie]

@shyamal890 I can change it as describe above but shouldn't there be a out of the box working solution? If I change it to the above behavior everybody needs to make adjustments instead of just using it as is? And if people want to make adjustments isn't it better that they use a custom theme?

[shyamal890]

@Jefiozie Hmm, I guess it should be something like this:

Expect for refreshAttr there should be a customRefreshAttr. When customRefreshAttr = true then and then only the code below will take effect otherwise a default loading div is shown

              <div ui-select-refresh>
                        //Where user can put in whatever they want
              </div>

What do you think?

[Jefiozie]

I still believe the implementation as it is now is a good solution. People van use custom theme for custom behaviour/style

[user378230]

I still believe the implementation as it is now is a good solution. People van use custom theme for custom behaviour/style

Agreed.