This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Change Property Prefix from "_" to "$" so that angular built-in functions ignore them #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note that this could be a breaking change. |
|
I'd prefer another solution, because you also can use a string list in a repeat: #1661 |
user378230
added a commit
to user378230/ui-select
that referenced
this pull request
Jul 8, 2016
Previously the item from the list was modified with the _uiSelectChoiceDisabled property. This allowed a leakage of information from ui-select to outside the directive. It also caused issues when the was used outside of the directive. This commit adds a reference array to store disabled items and so prevents the need to modify the item in place. Closes angular-ui#1200 and angular-ui#1661 Partially supersedes angular-ui#1641
user378230
added a commit
to user378230/ui-select
that referenced
this pull request
Jul 9, 2016
Previously setting a selected item as locked modified that item, this could cause issues if the item was used outside of the directive. This commit changes the directive to store the information internally thus preventing it from interfering with external uses. Closes angular-ui#1269 and angular-ui#514 Supersedes (and closes) angular-ui#1641 and angular-ui#952
user378230
added a commit
to user378230/ui-select
that referenced
this pull request
Jul 9, 2016
Previously the item from the list was modified with the _uiSelectChoiceDisabled property. This allowed a leakage of information from ui-select to outside the directive. It also caused issues when the was used outside of the directive. This commit adds a reference array to store disabled items and so prevents the need to modify the item in place. Closes angular-ui#1200 and angular-ui#1661 Partially supersedes angular-ui#1641
user378230
added a commit
to user378230/ui-select
that referenced
this pull request
Jul 9, 2016
Previously setting a selected item as locked modified that item, this could cause issues if the item was used outside of the directive. This commit changes the directive to store the information internally thus preventing it from interfering with external uses. Closes angular-ui#1269 and angular-ui#514 Supersedes (and closes) angular-ui#1641 and angular-ui#952
user378230
added a commit
to user378230/ui-select
that referenced
this pull request
Jul 9, 2016
Previously setting a selected item as locked modified that item, this could cause issues if the item was used outside of the directive. This commit changes the directive to store the information internally thus preventing it from interfering with external uses. Closes angular-ui#1269 and angular-ui#514 Supersedes (and closes) angular-ui#1641 and angular-ui#952
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular's built in functions like angular.copy() and angular.toJson() automatically ignore object properties that are prefixed with $.
This PR changes the names of "_uiSelectChoiceDisabled" and "_uiSelectChoiceLocked" to "$uiSelectChoiceDisabled" and "$uiSelectChoiceLocked" respectively to make use of this feature when using ui-select as a model for rest resources.