This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Update npm package name in readme #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcbachmann Any chance you can grab the one on the pages site too? https://github.com/angular-ui/ui-select/blob/master/docs/index.html#L152 We don't own the other package so we can't deprecate it |
|
@user378230 done.
😢 |
|
🌟🌟🌟🌟🌟 Thanks! 😃 🌟🌟🌟🌟🌟 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the npm module name in the readme is wrong.
We've run into incompatibility issues because of that. (same error like in #224)
Can somebody also deprecate
angular-ui-selecton npm and point to the new name of the module, please.This pr fixes #1574