Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Clear button shown on disabled select #980

Closed
michalmatovcik opened this issue Jun 2, 2015 · 2 comments
Closed

Clear button shown on disabled select #980

michalmatovcik opened this issue Jun 2, 2015 · 2 comments

Comments

@michalmatovcik
Copy link

I have ui-select with ng-disabled =false.
Select itself behave as expected - so i cannot select another value.

But clear button (allow-clear=true) is still shown and working!

Suggestion:
I have fixed it in my own app - by changing setAllowClear function to set $select.allowClear to false if $select.disabled is true.

Next step is to call setAllowClear function from inside of $select.disabled watcher.

Please evaluate this bug and fix it.
thanks

@michalmatovcik
Copy link
Author

which version are you using? i have found it in latest release

2015-06-08 13:01 GMT+02:00 Sam Blowes notifications@github.com:

For me the clear button does not show when the input is disabled


Reply to this email directly or view it on GitHub
#980 (comment)
.

@wesleycho
Copy link
Contributor

Closing due to lack of reproduction in Plunker - feel free to open a new issue with a Plunker if it is still a problem.

user378230 pushed a commit that referenced this issue Apr 7, 2016
hide clear button if ui-select is disabled

Closes #1388 and #980
fcaballero pushed a commit to fcaballero/ui-select that referenced this issue Apr 17, 2016
hide clear button if ui-select is disabled

Closes angular-ui#1388 and angular-ui#980
fcaballero pushed a commit to fcaballero/ui-select that referenced this issue Apr 25, 2016
hide clear button if ui-select is disabled

Closes angular-ui#1388 and angular-ui#980
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants