Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Can´t select elements with mouse click when using TAGGING #1357

Closed
oezkany opened this issue Dec 14, 2015 · 2 comments · Fixed by #1439
Closed

Can´t select elements with mouse click when using TAGGING #1357

oezkany opened this issue Dec 14, 2015 · 2 comments · Fixed by #1439

Comments

@oezkany
Copy link

oezkany commented Dec 14, 2015

Hi,

I can not select any item of ui-select-choice list if I am using the tagging option.
Try out this example: https://github.com/angular-ui/ui-select/blob/master/examples/demo-tagging.html

Thanks.
@mattmcardle
Copy link

I just came across this issue too, although i don't think it is new as prior to today my version of ui-select hadn't been updated in over a month and the issue was present then.

@soyuka
Copy link
Contributor

soyuka commented Feb 12, 2016

+1, using tagging="scopeFn" tagging_label="false" selecting a choice in the list calls the scopeFn function with an empty string but never calls on-select.

Maybe related to #1312

soyuka added a commit to soyuka/ui-select that referenced this issue Feb 16, 2016
@soyuka
fix(uiSelectController): Select by click on non-multiple tagging
2ed4f8e 
When in tagging mode, not multiple (`taggingLabel === false`), selecting
an item by click was instead calling `taggingFunc()`. This fix checks
for this manual selection, whether `ctrl.search` is filled or not and
acts accordingly.

closes angular-ui#1357
@soyuka soyuka mentioned this issue Feb 16, 2016
Merged
aaronroberson added a commit that referenced this issue Feb 18, 2016
@aaronroberson
Merge pull request #1439 from soyuka/fixselectclicktagging
cb2fcf1 
fix(uiSelectController): select by click on non-multiple tagging

When in tagging mode, not multiple (taggingLabel === false), selecting
an item by click was instead calling taggingFunc(). This fix checks
for this manual selection, whether ctrl.search is filled or not and
acts accordingly.

closes #1357
@BrentWheeldon BrentWheeldon mentioned this issue Mar 16, 2016
Closed
brocksamson pushed a commit to brocksamson/ui-select that referenced this issue May 5, 2016
@soyuka @amMattM
fix(uiSelectController): Select by click on non-multiple tagging
ac76791 
When in tagging mode, not multiple (`taggingLabel === false`), selecting
an item by click was instead calling `taggingFunc()`. This fix checks
for this manual selection, whether `ctrl.search` is filled or not and
acts accordingly.

closes angular-ui#1357
aaronroberson pushed a commit that referenced this issue Jul 19, 2016
@kfedorov @aaronroberson
fix(uiSelectController): Select by click on non-multiple tagging (bis) (
3dfde71 
#1727)

* When in tagging mode, not multiple (taggingLabel === false), selecting
an item by click was instead calling taggingFunc(). This fix checks
for this manual selection, whether ctrl.search is filled or not and
acts accordingly.

Same changes mad in #1439 that were mysteriously lost.
Fixes #1357, #1496 and #1409

* Simplification to combine ctrl.clickTriggeredSelect in one assignment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(uiSelectController): Select by click on non-multiple tagging soyuka/ui-select
3 participants
@soyuka @mattmcardle @oezkany