Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$state.href inherit parameter fix #970

Merged
merged 1 commit into from
Mar 20, 2014
Merged

Conversation

nl5887
Copy link
Contributor

@nl5887 nl5887 commented Mar 19, 2014

fix($state.href): didn't complied to inherit parameter

$state.href didnt' complied to inherit parameter. Parameters aren't inherited anymore when inherit: false

@nateabele
Copy link
Contributor

Please read the contributor guidelines. Thanks.

@nl5887
Copy link
Contributor Author

nl5887 commented Mar 20, 2014

Ok, updated the commit comment.

@nateabele
Copy link
Contributor

The contributor guidelines also mention our use of unit tests to prove any issues that are reported. Also, the commit message should be fix($state): ... -- thanks.

$state.href didn't comply to inherit parameter. Parameters aren't
inherited anymore when inherit: false (default)
@nl5887
Copy link
Contributor Author

nl5887 commented Mar 20, 2014

updated comment & added tests for inherit enabled, disabled and default

nateabele added a commit that referenced this pull request Mar 20, 2014
$state.href inherit parameter fix
@nateabele nateabele merged commit f5c426b into angular-ui:master Mar 20, 2014
ncuillery added a commit to ncuillery/ui-router that referenced this pull request May 30, 2014
Since angular-ui#970, `href()` method takes into account the `inherit` option. This option needs to have a `true` default value in order to not introduce a breaking change.

Moreover, the `true` value is more convenient for this "high-level oriented" method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants