-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(popover): added template as per requests in issue #220, took code from jbruni #2479
Conversation
This looks great and simple - exactly what i need +1 |
Hi, @calekennedy |
Also, you say that @jbruni's fork is outdated, but it isn't...? |
@Siyfion oh, actually I just checked @jbruni's fork and problem that I described doesn't appear. Thanks. |
@calekennedy How do you pass scope to the new template? |
@Siyfion @jbruni is using a modified version of release 0.11 and core is using 0.12. Additionally, his fork was causing some state problems with the accordion directive. @Yuri-G I have no trouble with datepicker and I am using it pretty extensively. If you put up a link to plunkr or something, maybe we could figure out why it's breaking. @amcdnl The template is always going to be nested inside of a controller. The template will inherit its scope from this controller. |
@calekennedy I noticed you created a new template for this, is there anyway we can avoid having two templates for popovers? |
+1 for this, very helpful, thanks... |
Holy moly. It got merged! Finally. |
@calekennedy I'm noticing an issue similar to what @Yuri-G reported with binding ng-click in the template to the backing app controller. It works the first time the popover is opened but after that the backing function never gets hit. I set up a plunkr here to demonstrate: http://plnkr.co/edit/BoXoCxdXtIfmsdSTzOMU?p=preview The ui-bootstrap-tpls.js file I am using was built from this repository: https://github.com/calekennedy/bootstrap.git UPDATE
UPDATE Changing
fixed this issue for me, but I'm not sure of the implications. Also noticed in the tooltipProvider what seems to be an extra $digest in the createTooltip() function as $digest gets called again shortly after in the show() function. |
There seemed to be a huge amount of interest in merging in the type of templating @jbruni was using in his fork. However his fork is outdated. This leads to a feature disparity between his fork and the core library. One of my projects requires features from both version, so I took it upon myself to merge them. Hopefully this merge will find its way into the core library where it will help other users who require both sets of functionality. 😄