-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 - Support for Angular 17, new build system, new defaults #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2024
fmalcher
reviewed
Jan 26, 2024
JohannesHoppe
commented
Jan 26, 2024
fmalcher
reviewed
Jan 26, 2024
fmalcher
reviewed
Jan 26, 2024
fmalcher
reviewed
Jan 26, 2024
fmalcher
reviewed
Jan 26, 2024
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
fmalcher
reviewed
Jan 26, 2024
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
fmalcher
reviewed
Jan 26, 2024
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
fmalcher
reviewed
Jan 26, 2024
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
fmalcher
reviewed
Jan 26, 2024
fmalcher
reviewed
Jan 26, 2024
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
fmalcher
reviewed
Jan 26, 2024
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
fmalcher
reviewed
Jan 26, 2024
JohannesHoppe
commented
Jan 26, 2024
fmalcher
reviewed
Jan 26, 2024
fmalcher
reviewed
Jan 26, 2024
fmalcher
reviewed
Jan 26, 2024
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
fmalcher
reviewed
Jan 26, 2024
fmalcher
reviewed
Jan 26, 2024
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
fmalcher
reviewed
Jan 26, 2024
fmalcher
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--no-silent
option, error messages will be shown by default now (modern CI systems don't expose secrets anymore)--dir
option, this overrides the directory for all published sources, relative to the current working directory. The normal logic with buildTargets and conventions is ignored in this case.--no-notfound
option to not create a404.html
which should work great with Cloudflare pages, see Github Pages: Configuration to avoid initial 404 Network Response #178 and see https://developers.cloudflare.com/pages/configuration/serving-pages/#single-page-application-spa-rendering.nojekyll
file by default, can be disabled via--no-nojekyll
Install via
FYI Cloudflare docs: Single-page application (SPA) rendering
If your project does not include a top-level
404.html
file, Pages assumes that you are deploying a single-page application. This includes frameworks like React, Vue, and Angular. Pages’ default single-page application behavior matches all incoming paths to the root (/), allowing you to capture URLs like /about or /help and respond to them from within your SPA.