refactor(underscoreStringFilter): Remove underscore string filter

Remove underscore string as 3rd dependency BREAKING CHANGE: Underscore string filter has been completely removed
angular-macgyver · Dec 16, 2015 · c9ec969 · c9ec969
1 parent ad144e2
commit c9ec969
Show file tree

Hide file tree

Showing 9 changed files with 2 additions and 89 deletions.
diff --git a/README.md b/README.md
@@ -30,11 +30,9 @@ Duct Tape and a Swiss Army Knife. Angular helpers for all your friends!
  - Boolean
  - Pluralize
  - Timestamp
- - Underscore String
 
 ## 3rd party libraries dependencies ##
  - AngularJS (1.2.x+)
- - Underscore String (Underscore string filter)
 
 ## Using MacGyver ##
 You can install via [Bower](http://www.bower.io) or download from [Github](https://github.com/angular-macgyver/MacGyver/archive/master.zip)

diff --git a/bower.json b/bower.json
@@ -19,7 +19,6 @@
   },
   "dependencies": {
     "angular": "~1.3.0",
-    "angular-animate": "~1.3.0",
-    "underscore.string": "~2.3.3"
+    "angular-animate": "~1.3.0"
   }
 }
diff --git a/docs/filters.jade b/docs/filters.jade
@@ -2,9 +2,6 @@ extends layout
 
 block append nav
   ul.nav.nav-list.docs-sidenav(mac-affix)
-    li(mac-scroll-spy-target="underscore-string"): a(href="#underscore-string")
-      i.icon-chevron-right
-      | Underscore String Filter
     li(mac-scroll-spy-target="pluralize-filter"): a(href="#pluralize-filter")
       i.icon-chevron-right
       | Pluralize Filter
@@ -16,16 +13,6 @@ block append nav
       | List Filter
 
 block append content
-  section#underscore-string(mac-scroll-spy-anchor)
-    | @@include("docs/html/filters/underscore.html")
-    h3 Example
-    .docs-example
-      p {{ "this_Is_aTestFor_Underscore_string" | underscoreString: "humanize" }}
-      p {{ "Truncating: lorem ipsum dolor sit amet, consectetur adipiscing elit." | underscoreString: "truncate": 42 }}
-      p {{ "Pruning: lorem ipsum dolor sit amet, consectetur adipiscing elit." | underscoreString: "prune": 42: "... (show more)" }}
-    pre.prettyprint.linenums.
-      &lt;p&gt;{{ &quot;this_Is_aTestFor_Underscore_string&quot; | underscoreString: &quot;humanize&quot; }}&lt;/p&gt;
-
   section#pluralize-filter(mac-scroll-spy-anchor)
     | @@include("docs/html/filters/pluralize.html")
     h3 Example

diff --git a/docs/filters/underscore.md b/docs/filters/underscore.md
diff --git a/docs/html/filters/underscore.html b/docs/html/filters/underscore.html
diff --git a/docs/layout.jade b/docs/layout.jade
@@ -77,7 +77,6 @@ html
 
     script(src="//cdnjs.cloudflare.com/ajax/libs/prettify/r298/prettify.js", type="text/javascript")
     script(src="//ajax.googleapis.com/ajax/libs/angularjs/1.3.0/angular.min.js", type="text/javascript")
-    script(src="//cdnjs.cloudflare.com/ajax/libs/underscore.string/2.3.3/underscore.string.min.js", type="text/javascript")
     script(src="//code.angularjs.org/1.3.0/angular-animate.js", type="text/javascript")
     script(src='js/MacGyver.js', type="text/javascript")
     script(src="js/doc.js", type="text/javascript")

diff --git a/docs/util.jade b/docs/util.jade
@@ -82,7 +82,7 @@ block append content
 
   section#capitalize(mac-scroll-spy-anchor)
     h3 capitalize
-    p Converts first leter of the string to uppercase (Underscore string proxy)
+    p Converts first leter of the string to uppercase
     pre.prettyprint.
       util.capitalize("lowercase")
       =&gt; "Lowercase"

diff --git a/src/filters/underscore.string.js b/src/filters/underscore.string.js
diff --git a/test/unit/filters.underscore.string.spec.js b/test/unit/filters.underscore.string.spec.js