Merge pull request #1130 from angular/main

Create a new pull request by comparing changes across two branches
angular-indonesia · Oct 21, 2024 · e7c7d11 · e7c7d11
2 parents 933a18d + 94dbacf
commit e7c7d11
Show file tree

Hide file tree

Showing 37 changed files with 298 additions and 336 deletions.
diff --git a/modules/testing/builder/projects/hello-world-app/src/app/app.component.ts b/modules/testing/builder/projects/hello-world-app/src/app/app.component.ts
@@ -10,6 +10,7 @@ import { Component } from '@angular/core';
 
 @Component({
   selector: 'app-root',
+  standalone: false,
   templateUrl: './app.component.html',
   styleUrls: ['./app.component.css'],
 })

diff --git a/package.json b/package.json
@@ -52,23 +52,23 @@
   },
   "devDependencies": {
     "@ampproject/remapping": "2.3.0",
-    "@angular/animations": "19.0.0-next.9",
+    "@angular/animations": "19.0.0-next.10",
     "@angular/bazel": "patch:@angular/bazel@https%3A//github.com/angular/bazel-builds.git%23commit=07617f0f8540d27f8895b1820a6f994e1e5b7277#~/.yarn/patches/@angular-bazel-https-9848736cf4.patch",
     "@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#2692c81ef1068e15c7b7eaf3ecc7a65cbdd25c9f",
-    "@angular/cdk": "19.0.0-next.8",
-    "@angular/common": "19.0.0-next.9",
-    "@angular/compiler": "19.0.0-next.9",
-    "@angular/compiler-cli": "19.0.0-next.9",
-    "@angular/core": "19.0.0-next.9",
-    "@angular/forms": "19.0.0-next.9",
-    "@angular/localize": "19.0.0-next.9",
-    "@angular/material": "19.0.0-next.8",
+    "@angular/cdk": "19.0.0-next.9",
+    "@angular/common": "19.0.0-next.10",
+    "@angular/compiler": "19.0.0-next.10",
+    "@angular/compiler-cli": "19.0.0-next.10",
+    "@angular/core": "19.0.0-next.10",
+    "@angular/forms": "19.0.0-next.10",
+    "@angular/localize": "19.0.0-next.10",
+    "@angular/material": "19.0.0-next.9",
     "@angular/ng-dev": "https://github.com/angular/dev-infra-private-ng-dev-builds.git#2659cef857ffd127dbbbcbb28bb2dc4ca8625b50",
-    "@angular/platform-browser": "19.0.0-next.9",
-    "@angular/platform-browser-dynamic": "19.0.0-next.9",
-    "@angular/platform-server": "19.0.0-next.9",
-    "@angular/router": "19.0.0-next.9",
-    "@angular/service-worker": "19.0.0-next.9",
+    "@angular/platform-browser": "19.0.0-next.10",
+    "@angular/platform-browser-dynamic": "19.0.0-next.10",
+    "@angular/platform-server": "19.0.0-next.10",
+    "@angular/router": "19.0.0-next.10",
+    "@angular/service-worker": "19.0.0-next.10",
     "@babel/core": "7.25.8",
     "@babel/generator": "7.25.7",
     "@babel/helper-annotate-as-pure": "7.25.7",
@@ -84,7 +84,7 @@
     "@bazel/concatjs": "patch:@bazel/concatjs@npm%3A5.8.1#~/.yarn/patches/@bazel-concatjs-npm-5.8.1-1bf81df846.patch",
     "@bazel/jasmine": "patch:@bazel/jasmine@npm%3A5.8.1#~/.yarn/patches/@bazel-jasmine-npm-5.8.1-3370fee155.patch",
     "@bazel/runfiles": "^5.8.1",
-    "@discoveryjs/json-ext": "0.6.1",
+    "@discoveryjs/json-ext": "0.6.2",
     "@inquirer/confirm": "5.0.0",
     "@inquirer/prompts": "7.0.0",
     "@listr2/prompt-adapter-inquirer": "2.0.17",
@@ -114,8 +114,8 @@
     "@types/yargs": "^17.0.20",
     "@types/yargs-parser": "^21.0.0",
     "@types/yarnpkg__lockfile": "^1.1.5",
-    "@typescript-eslint/eslint-plugin": "8.9.0",
-    "@typescript-eslint/parser": "8.9.0",
+    "@typescript-eslint/eslint-plugin": "8.10.0",
+    "@typescript-eslint/parser": "8.10.0",
     "@vitejs/plugin-basic-ssl": "1.1.0",
     "@web/test-runner": "^0.19.0",
     "@yarnpkg/lockfile": "1.1.0",
@@ -172,7 +172,7 @@
     "npm-pick-manifest": "10.0.0",
     "open": "10.1.0",
     "ora": "5.4.1",
-    "pacote": "19.0.1",
+    "pacote": "20.0.0",
     "parse5-html-rewriting-stream": "7.0.0",
     "picomatch": "4.0.2",
     "piscina": "4.7.0",
@@ -186,7 +186,7 @@
     "rollup": "4.24.0",
     "rollup-plugin-sourcemaps": "^0.6.0",
     "rxjs": "7.8.1",
-    "sass": "1.79.5",
+    "sass": "1.80.2",
     "sass-loader": "16.0.2",
     "semver": "7.6.3",
     "shelljs": "^0.8.5",

diff --git a/packages/angular/build/package.json b/packages/angular/build/package.json
@@ -39,7 +39,7 @@
     "picomatch": "4.0.2",
     "piscina": "4.7.0",
     "rollup": "4.24.0",
-    "sass": "1.79.5",
+    "sass": "1.80.2",
     "semver": "7.6.3",
     "vite": "5.4.9",
     "watchpack": "2.4.2"

diff --git a/packages/angular/build/src/builders/application/tests/behavior/rebuild-errors_spec.ts b/packages/angular/build/src/builders/application/tests/behavior/rebuild-errors_spec.ts
@@ -27,7 +27,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
 
       const goodDirectiveContents = `
         import { Directive, Input } from '@angular/core';
-        @Directive({ selector: 'dir' })
+        @Directive({ selector: 'dir', standalone: false })
         export class Dir {
           @Input() foo: number;
         }
@@ -66,6 +66,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
         import { Component } from '@angular/core'
         @Component({
           selector: 'app-root',
+          standalone: false,
           template: '<dir [foo]="123">',
         })
         export class AppComponent { }
@@ -87,7 +88,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
                   'src/app/dir.ts',
                   `
                   import { Directive, Input } from '@angular/core';
-                  @Directive({ selector: 'dir' })
+                  @Directive({ selector: 'dir', standalone: false })
                   export class Dir {
                     @Input() foo: string;
                   }

diff --git a/packages/angular/build/src/builders/application/tests/behavior/rebuild-general_spec.ts b/packages/angular/build/src/builders/application/tests/behavior/rebuild-general_spec.ts
@@ -38,6 +38,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
         import './file-a';
         @Component({
           selector: 'app-root',
+          standalone: false,
           template: 'App component',
         })
         export class AppComponent { }

diff --git a/packages/angular/build/src/builders/application/tests/behavior/rebuild-web-workers_spec.ts b/packages/angular/build/src/builders/application/tests/behavior/rebuild-web-workers_spec.ts
@@ -47,6 +47,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
         import { Component } from '@angular/core'
         @Component({
           selector: 'app-root',
+          standalone: false,
           template: '<h1>Worker Test</h1>',
         })
         export class AppComponent {

diff --git a/...ges/angular/build/src/builders/application/tests/behavior/web-workers-application_spec.ts b/...ges/angular/build/src/builders/application/tests/behavior/web-workers-application_spec.ts
@@ -42,6 +42,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
         import { Component } from '@angular/core'
         @Component({
           selector: 'app-root',
+          standalone: false,
           template: '<h1>Worker Test</h1>',
         })
         export class AppComponent {

diff --git a/packages/angular/build/src/builders/application/tests/options/app-shell_spec.ts b/packages/angular/build/src/builders/application/tests/options/app-shell_spec.ts
@@ -16,6 +16,7 @@ const appShellRouteFiles: Record<string, string> = {
 
     @Component({
       selector: 'app-app-shell',
+      standalone: false,
       styles: ['div { color: #fff; }'],
       template: '<p>app-shell works!</p>',
     })

diff --git a/packages/angular/build/src/builders/application/tests/options/external-dependencies_spec.ts b/packages/angular/build/src/builders/application/tests/options/external-dependencies_spec.ts
@@ -61,6 +61,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
           import { Component } from '@angular/core'
           @Component({
             selector: 'app-root',
+            standalone: false,
             template: '<h1>Worker Test</h1>',
           })
           export class AppComponent {

diff --git a/packages/angular/build/src/tools/vite/middlewares/assets-middleware.ts b/packages/angular/build/src/tools/vite/middlewares/assets-middleware.ts
@@ -88,7 +88,7 @@ export function createAngularAssetsMiddleware(
             // Shim the stylesheet if a component ID is provided
             if (componentId.length > 0) {
               // Validate component ID
-              if (/^[_.\-\p{Letter}\d]+-c\d{9}$/u.test(componentId)) {
+              if (/^[_.\-\p{Letter}\d]+-c\d+$/u.test(componentId)) {
                 loadEsmModule<typeof import('@angular/compiler')>('@angular/compiler')
                   .then((compilerModule) => {
                     const encapsulatedData = compilerModule.encapsulateStyle(

diff --git a/packages/angular/build/src/utils/index-file/html-rewriting-stream.ts b/packages/angular/build/src/utils/index-file/html-rewriting-stream.ts
@@ -8,10 +8,16 @@
 
 import { Readable } from 'node:stream';
 import { pipeline } from 'node:stream/promises';
+import type { RewritingStream } from 'parse5-html-rewriting-stream';
 import { loadEsmModule } from '../load-esm';
 
+// Export helper types for the rewriter
+export type StartTag = Parameters<RewritingStream['emitStartTag']>[0];
+export type EndTag = Parameters<RewritingStream['emitEndTag']>[0];
+export type { RewritingStream };
+
 export async function htmlRewritingStream(content: string): Promise<{
-  rewriter: import('parse5-html-rewriting-stream').RewritingStream;
+  rewriter: RewritingStream;
   transformedContent: () => Promise<string>;
 }> {
   const { RewritingStream } = await loadEsmModule<typeof import('parse5-html-rewriting-stream')>(

diff --git a/packages/angular/cli/package.json b/packages/angular/cli/package.json
@@ -34,7 +34,7 @@
     "listr2": "8.2.5",
     "npm-package-arg": "12.0.0",
     "npm-pick-manifest": "10.0.0",
-    "pacote": "19.0.1",
+    "pacote": "20.0.0",
     "resolve": "1.22.8",
     "semver": "7.6.3",
     "symbol-observable": "4.0.0",

diff --git a/packages/angular/ssr/package.json b/packages/angular/ssr/package.json
@@ -22,14 +22,15 @@
     "@angular/router": "^19.0.0-next.0"
   },
   "devDependencies": {
-    "@angular/common": "19.0.0-next.9",
-    "@angular/compiler": "19.0.0-next.9",
-    "@angular/core": "19.0.0-next.9",
-    "@angular/platform-browser": "19.0.0-next.9",
-    "@angular/platform-server": "19.0.0-next.9",
-    "@angular/router": "19.0.0-next.9",
+    "@angular/common": "19.0.0-next.10",
+    "@angular/compiler": "19.0.0-next.10",
+    "@angular/core": "19.0.0-next.10",
+    "@angular/platform-browser": "19.0.0-next.10",
+    "@angular/platform-server": "19.0.0-next.10",
+    "@angular/router": "19.0.0-next.10",
     "@bazel/runfiles": "^5.8.1"
   },
+  "sideEffects": false,
   "schematics": "./schematics/collection.json",
   "repository": {
     "type": "git",

diff --git a/packages/angular/ssr/src/app-engine.ts b/packages/angular/ssr/src/app-engine.ts
@@ -30,7 +30,7 @@ export class AngularAppEngine {
    *
    * @private
    */
-  static ɵhooks = new Hooks();
+  static ɵhooks = /* #__PURE__*/ new Hooks();
 
   /**
    * Provides access to the hooks for extending or modifying the server application's behavior.

diff --git a/packages/angular_devkit/build_angular/package.json b/packages/angular_devkit/build_angular/package.json
@@ -20,7 +20,7 @@
     "@babel/plugin-transform-runtime": "7.25.7",
     "@babel/preset-env": "7.25.8",
     "@babel/runtime": "7.25.7",
-    "@discoveryjs/json-ext": "0.6.1",
+    "@discoveryjs/json-ext": "0.6.2",
     "@ngtools/webpack": "0.0.0-PLACEHOLDER",
     "@vitejs/plugin-basic-ssl": "1.1.0",
     "ansi-colors": "4.1.3",
@@ -48,7 +48,7 @@
     "postcss-loader": "8.1.1",
     "resolve-url-loader": "5.0.0",
     "rxjs": "7.8.1",
-    "sass": "1.79.5",
+    "sass": "1.80.2",
     "sass-loader": "16.0.2",
     "semver": "7.6.3",
     "source-map-loader": "5.0.0",

diff --git a/packages/angular_devkit/build_angular/src/builders/app-shell/app-shell_spec.ts b/packages/angular_devkit/build_angular/src/builders/app-shell/app-shell_spec.ts
@@ -34,6 +34,7 @@ describe('AppShell Builder', () => {
 
       @Component({
         selector: 'app-app-shell',
+        standalone: false,
         templateUrl: './app-shell.component.html',
       })
       export class AppShellComponent implements OnInit {

diff --git a/packages/angular_devkit/build_angular/src/builders/browser/specs/styles_spec.ts b/packages/angular_devkit/build_angular/src/builders/browser/specs/styles_spec.ts
@@ -73,6 +73,7 @@ describe('Browser Builder styles', () => {
 
         @Component({
           selector: 'app-root',
+          standalone: false,
           templateUrl: './app.component.html',
           styleUrls: []
         })
@@ -92,6 +93,7 @@ describe('Browser Builder styles', () => {
 
         @Component({
           selector: 'app-root',
+          standalone: false,
           templateUrl: './app.component.html',
           styles: ['div { mask-composite: add; }'],
         })
@@ -118,6 +120,7 @@ describe('Browser Builder styles', () => {
 
         @Component({
           selector: 'app-root',
+          standalone: false,
           templateUrl: './app.component.html',
           styles: ['div { mask-composite: add; }'],
         })
@@ -637,6 +640,7 @@ describe('Browser Builder styles', () => {
 
         @Component({
           selector: 'app-root',
+          standalone: false,
           templateUrl: './app.component.html',
           styleUrls: ['../styles.css']
         })

diff --git a/packages/angular_devkit/build_angular/src/builders/browser/specs/svg_spec.ts b/packages/angular_devkit/build_angular/src/builders/browser/specs/svg_spec.ts
@@ -33,6 +33,7 @@ describe('Browser Builder allow svg', () => {
 
         @Component({
           selector: 'app-root',
+          standalone: false,
           templateUrl: './app.component.svg',
           styleUrls: []
         })

diff --git a/...s/angular_devkit/build_angular/src/builders/browser/tests/behavior/rebuild-errors_spec.ts b/...s/angular_devkit/build_angular/src/builders/browser/tests/behavior/rebuild-errors_spec.ts
@@ -22,7 +22,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
 
       const goodDirectiveContents = `
         import { Directive, Input } from '@angular/core';
-        @Directive({ selector: 'dir' })
+        @Directive({ selector: 'dir', standalone: false })
         export class Dir {
           @Input() foo: number;
         }
@@ -61,6 +61,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
         import { Component } from '@angular/core'
         @Component({
           selector: 'app-root',
+          standalone: false,
           template: '<dir [foo]="123">',
         })
         export class AppComponent { }
@@ -82,7 +83,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
                   'src/app/dir.ts',
                   `
                   import { Directive, Input } from '@angular/core';
-                  @Directive({ selector: 'dir' })
+                  @Directive({ selector: 'dir', standalone: false })
                   export class Dir {
                     @Input() foo: string;
                   }
@@ -162,7 +163,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
         'src/app/dir.ts',
         `
         import { Directive, Input } from '@angular/core';
-        @Directive({ selector: 'dir' })
+        @Directive({ selector: 'dir', standalone: false })
         export class Dir {
           @Input() foo: number;
         }
@@ -172,7 +173,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
       // Same selector with a different type on the `foo` property but initially no `@Input`
       const goodDirectiveContents = `
         import { Directive } from '@angular/core';
-        @Directive({ selector: 'dir' })
+        @Directive({ selector: 'dir', standalone: false })
         export class Dir2 {
           foo: string;
         }
@@ -210,6 +211,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
         import { Component } from '@angular/core'
         @Component({
           selector: 'app-root',
+          standalone: false,
           template: '<dir [foo]="123">',
         })
         export class AppComponent { }
@@ -231,7 +233,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
                   'src/app/dir2.ts',
                   `
                   import { Directive, Input } from '@angular/core';
-                  @Directive({ selector: 'dir' })
+                  @Directive({ selector: 'dir', standalone: false })
                   export class Dir2 {
                     @Input() foo: string;
                   }

diff --git a/packages/angular_devkit/build_angular/src/builders/karma/tests/behavior/fake-async_spec.ts b/packages/angular_devkit/build_angular/src/builders/karma/tests/behavior/fake-async_spec.ts
@@ -22,6 +22,7 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {
 
             @Component({
               selector: 'app-root',
+              standalone: false,
               template: '<button (click)="changeMessage()" class="change">{{ message }}</button>',
             })
             export class AppComponent {

diff --git a/packages/angular_devkit/build_angular/src/builders/karma/tests/options/assets_spec.ts b/packages/angular_devkit/build_angular/src/builders/karma/tests/options/assets_spec.ts
@@ -47,6 +47,7 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {
 
             @Component({
               selector: 'app-root',
+              standalone: false,
               template: '<p *ngFor="let asset of assets">{{ asset.content }}</p>'
             })
             export class AppComponent {

diff --git a/packages/angular_devkit/build_angular/src/builders/karma/tests/options/code-coverage_spec.ts b/packages/angular_devkit/build_angular/src/builders/karma/tests/options/code-coverage_spec.ts
@@ -79,6 +79,7 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {
 
           @Component({
             selector: 'app-root',
+            standalone: false,
             templateUrl: './app.component.html',
             styleUrls: ['./app.component.css']
           })

diff --git a/packages/angular_devkit/build_angular/src/builders/karma/tests/options/styles_spec.ts b/packages/angular_devkit/build_angular/src/builders/karma/tests/options/styles_spec.ts
@@ -23,6 +23,7 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {
 
           @Component({
             selector: 'app-root',
+            standalone: false,
             template: '<p>Hello World</p>'
           })
           export class AppComponent {
@@ -79,6 +80,7 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {
         import { HttpClient } from '@angular/common/http';
         @Component({
           selector: 'app-root',
+          standalone: false,
           template: '<p *ngFor="let asset of css">{{ asset.content }}</p>'
         })
         export class AppComponent {