Merge pull request #1121 from angular/main

Create a new pull request by comparing changes across two branches
angular-indonesia · Sep 5, 2024 · 67967f9 · 67967f9
2 parents 0160017 + 84e14d6
commit 67967f9
Show file tree

Hide file tree

Showing 40 changed files with 1,324 additions and 1,296 deletions.
diff --git a/.github/workflows/assistant-to-the-branch-manager.yml b/.github/workflows/assistant-to-the-branch-manager.yml
@@ -16,6 +16,6 @@ jobs:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
         with:
           persist-credentials: false
-      - uses: angular/dev-infra/github-actions/branch-manager@b1788b992db2885b354aea52bde0b2a6fa56efa3
+      - uses: angular/dev-infra/github-actions/branch-manager@18033eeb81c00d6867f980105fa503721ada7aa3
         with:
           angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -21,7 +21,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Install node modules
         run: yarn install --immutable
       - name: Generate JSON schema types
@@ -42,11 +42,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Install node modules
         run: yarn install --immutable
       - name: Build release targets
@@ -56,11 +56,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Install node modules
         run: yarn install --immutable
       - name: Run module and package tests
@@ -90,13 +90,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Run CLI E2E tests
         run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
 
@@ -111,13 +111,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Run CLI E2E tests
         run: yarn bazel test --define=E2E_SHARD_TOTAL=3 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
 
@@ -132,13 +132,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Run CLI E2E tests
         run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.snapshots.${{ matrix.subset }}_node${{ matrix.node }}
 
@@ -149,13 +149,13 @@ jobs:
       SAUCE_TUNNEL_IDENTIFIER: angular-cli-${{ github.workflow }}-${{ github.run_number }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Run E2E Browser tests
         env:
           SAUCE_USERNAME: ${{ vars.SAUCE_USERNAME }}
@@ -170,7 +170,7 @@ jobs:
           ./scripts/saucelabs/wait-for-tunnel.sh
           yarn bazel test --config=saucelabs //tests/legacy-cli:e2e.saucelabs
           ./scripts/saucelabs/stop-tunnel.sh
-      - uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
+      - uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
         if: ${{ failure() }}
         with:
           name: sauce-connect-log
@@ -182,11 +182,11 @@ jobs:
       CIRCLE_BRANCH: ${{ github.ref_name }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
       - run: yarn admin snapshots --verbose
         env:
           SNAPSHOT_BUILDS_GITHUB_TOKEN: ${{ secrets.SNAPSHOT_BUILDS_GITHUB_TOKEN }}
diff --git a/.github/workflows/dev-infra.yml b/.github/workflows/dev-infra.yml
@@ -13,13 +13,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-      - uses: angular/dev-infra/github-actions/commit-message-based-labels@b1788b992db2885b354aea52bde0b2a6fa56efa3
+      - uses: angular/dev-infra/github-actions/commit-message-based-labels@18033eeb81c00d6867f980105fa503721ada7aa3
         with:
           angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}
   post_approval_changes:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-      - uses: angular/dev-infra/github-actions/post-approval-changes@b1788b992db2885b354aea52bde0b2a6fa56efa3
+      - uses: angular/dev-infra/github-actions/post-approval-changes@18033eeb81c00d6867f980105fa503721ada7aa3
         with:
           angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}
diff --git a/.github/workflows/feature-requests.yml b/.github/workflows/feature-requests.yml
@@ -16,6 +16,6 @@ jobs:
     if: github.repository == 'angular/angular-cli'
     runs-on: ubuntu-latest
     steps:
-      - uses: angular/dev-infra/github-actions/feature-request@b1788b992db2885b354aea52bde0b2a6fa56efa3
+      - uses: angular/dev-infra/github-actions/feature-request@18033eeb81c00d6867f980105fa503721ada7aa3
         with:
           angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -34,7 +34,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup ESLint Caching
         uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
         with:
@@ -54,7 +54,7 @@ jobs:
       - name: Run Validation
         run: yarn admin validate
       - name: Check Package Licenses
-        uses: angular/dev-infra/github-actions/linting/licenses@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/linting/licenses@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Check tooling setup
         run: yarn check-tooling-setup
       - name: Check commit message
@@ -70,17 +70,17 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Install node modules
         run: yarn install --immutable
       - name: Build release targets
         run: yarn ng-dev release build
       - name: Store PR release packages
-        uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
+        uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
         with:
           name: packages
           path: dist/releases/*.tgz
@@ -90,11 +90,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Install node modules
         run: yarn install --immutable
       - name: Run module and package tests
@@ -111,13 +111,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Run CLI E2E tests
         run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
 
@@ -132,13 +132,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Run CLI E2E tests
         run: yarn bazel test --define=E2E_SHARD_TOTAL=3 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
 
@@ -155,12 +155,12 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@b1788b992db2885b354aea52bde0b2a6fa56efa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
       - name: Run CLI E2E tests
         run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.snapshots.${{ matrix.subset }}_node${{ matrix.node }}
diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml
@@ -38,7 +38,7 @@ jobs:
 
       # Upload the results as artifacts.
       - name: 'Upload artifact'
-        uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
+        uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
         with:
           name: SARIF file
           path: results.sarif

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,33 @@
+<a name="19.0.0-next.3"></a>
+
+# 19.0.0-next.3 (2024-09-04)
+
+### @angular-devkit/build-angular
+
+| Commit                                                                                              | Type | Description                                                 |
+| --------------------------------------------------------------------------------------------------- | ---- | ----------------------------------------------------------- |
+| [3ee21631f](https://github.com/angular/angular-cli/commit/3ee21631f481b2e72be2390b5a2cac74824efbb5) | fix  | clear context in Karma by default for single run executions |
+
+### @angular/ssr
+
+| Commit                                                                                              | Type | Description                                                                              |
+| --------------------------------------------------------------------------------------------------- | ---- | ---------------------------------------------------------------------------------------- |
+| [455b5700c](https://github.com/angular/angular-cli/commit/455b5700c29845829235e17efec320e634553108) | feat | expose `writeResponseToNodeResponse` and `createWebRequestFromNodeRequest` in public API |
+
+<!-- CHANGELOG SPLIT MARKER -->
+
+<a name="18.2.3"></a>
+
+# 18.2.3 (2024-09-04)
+
+### @angular-devkit/build-angular
+
+| Commit                                                                                              | Type | Description                                |
+| --------------------------------------------------------------------------------------------------- | ---- | ------------------------------------------ |
+| [482076612](https://github.com/angular/angular-cli/commit/482076612cac4b6565fc1b5e89ff9ca207653f87) | fix  | update `webpack-dev-middleware` to `7.4.2` |
+
+<!-- CHANGELOG SPLIT MARKER -->
+
 <a name="18.2.2"></a>
 
 # 18.2.2 (2024-08-29)

diff --git a/goldens/circular-deps/packages.json b/goldens/circular-deps/packages.json
@@ -12,6 +12,11 @@
     "packages/angular/build/src/tools/esbuild/utils.ts",
     "packages/angular/build/src/tools/esbuild/bundler-execution-result.ts"
   ],
+  [
+    "packages/angular/build/src/tools/esbuild/bundler-context.ts",
+    "packages/angular/build/src/tools/esbuild/utils.ts",
+    "packages/angular/build/src/utils/server-rendering/manifest.ts"
+  ],
   [
     "packages/angular/build/src/tools/esbuild/bundler-execution-result.ts",
     "packages/angular/build/src/tools/esbuild/utils.ts"